From: Antony Kurniawan Soemardi <linux@smankusors.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Max Shevchenko <wctrl@proton.me>,
Rudraksha Gupta <guptarud@gmail.com>
Subject: Re: [PATCH 5/5] ARM: dts: qcom: add device tree for Sony Xperia SP
Date: Sat, 14 Jun 2025 20:46:41 +0000 (UTC) [thread overview]
Message-ID: <39a7153e-1a4f-4dfc-a190-3b3370646d47@smankusors.com> (raw)
In-Reply-To: <f1284637-7650-498a-b850-b5140c47e4e0@oss.qualcomm.com>
On 6/15/2025 1:36 AM, Konrad Dybcio wrote:
> IIUC (and that's a 10yo range memory), SP had some eyebrow-rising boot
> flow (some partitions were non-standard?) - could you please add a
> paragraph about it in the commit message if that's the case, and maybe
> include a short how-to on booting the thing?
Is it acceptable to provide the pmOS wiki link in the commit message
instead?
https://wiki.postmarketos.org/wiki/Sony_Xperia_SP_(sony-huashan)
Or should I include a paragraph explaining it? It might be lengthy since
I'd need to add download links for the mkelf and the RPM blob.
But in a nutshell, concatenate the kernel with the DTB, create a SonyELF
boot image, and then boot it.
> As for the code.. I don't really have comments other than please
> keep a \n before 'status', other things seem rather in order.. If
> the dt checker doesn't complain, I don't see any logical wrongs
>
> Konrad
Thanks for the review. Going to sent the second version later.
As for the other things... well in my opinion it's not kinda in order,
especially the nodes ordering at qcom-msm8960.dtsi. Welp that might be
a separate patch I think...
Thanks,
Antony K. S.
next prev parent reply other threads:[~2025-06-14 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 17:50 [PATCH 0/5] Add support " Antony Kurniawan Soemardi
2025-06-13 17:50 ` [PATCH 1/5] ARM: dts: qcom: msm8960: add sdcc3 pinctrl states Antony Kurniawan Soemardi
2025-06-14 18:30 ` Konrad Dybcio
2025-06-13 17:50 ` [PATCH 2/5] ARM: dts: qcom: msm8960: add gsbi8 and its serial configuration Antony Kurniawan Soemardi
2025-06-14 18:32 ` Konrad Dybcio
2025-06-13 17:50 ` [PATCH 3/5] ARM: dts: qcom: msm8960: disable gsbi1 and gsbi5 nodes in msm8960 dtsi Antony Kurniawan Soemardi
2025-06-14 18:33 ` Konrad Dybcio
2025-06-13 17:50 ` [PATCH 4/5] dt-bindings: arm: qcom: add Sony Xperia SP Antony Kurniawan Soemardi
2025-06-13 17:51 ` [PATCH 5/5] ARM: dts: qcom: add device tree for " Antony Kurniawan Soemardi
2025-06-14 18:36 ` Konrad Dybcio
2025-06-14 20:46 ` Antony Kurniawan Soemardi [this message]
2025-06-15 12:35 ` Dmitry Baryshkov
2025-06-16 11:48 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a7153e-1a4f-4dfc-a190-3b3370646d47@smankusors.com \
--to=linux@smankusors.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wctrl@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®