From: Joe Perches <joe@perches.com>
To: Alban Bedel <albeu@free.fr>, linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: ath79: Remove some useless includes
Date: Wed, 16 Jan 2019 12:06:41 -0800 [thread overview]
Message-ID: <39a7f5c0177dc72033cb6f43a16d93407db7e182.camel@perches.com> (raw)
In-Reply-To: <20190116185549.23295-5-albeu@free.fr>
On Wed, 2019-01-16 at 19:55 +0100, Alban Bedel wrote:
> Several include are not needed, remove them to keep the list clean.
[]
> diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
[]
> @@ -12,15 +12,12 @@
> *
> */
>
> -#include <linux/kernel.h>
I think it's not a good idea to remove kernel.h
just because module.h indirectly #includes it via
moduleparam.h
next prev parent reply other threads:[~2019-01-16 20:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 18:55 [PATCH 1/6] spi: bitbang: Don't call chipselect() in spi_bitbang_setup() Alban Bedel
2019-01-16 18:55 ` [PATCH 2/6] spi: ath79: Simplify ath79_spi_chipselect() Alban Bedel
2019-01-17 12:40 ` Applied "spi: ath79: Simplify ath79_spi_chipselect()" to the spi tree Mark Brown
2019-01-16 18:55 ` [PATCH 3/6] spi: ath79: Enable support for compile test Alban Bedel
2019-01-17 12:40 ` Applied "spi: ath79: Enable support for compile test" to the spi tree Mark Brown
2019-01-16 18:55 ` [PATCH 4/6] spi: ath79: Remove now useless code Alban Bedel
2019-01-17 12:40 ` Applied "spi: ath79: Remove now useless code" to the spi tree Mark Brown
2019-01-16 18:55 ` [PATCH 5/6] spi: ath79: Remove some useless includes Alban Bedel
2019-01-16 20:06 ` Joe Perches [this message]
2019-01-16 18:55 ` [PATCH 6/6] MAINTAINERS: Add an entry for the ath79 SPI driver Alban Bedel
2019-01-17 12:40 ` Applied "spi: bitbang: Don't call chipselect() in spi_bitbang_setup()" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a7f5c0177dc72033cb6f43a16d93407db7e182.camel@perches.com \
--to=joe@perches.com \
--cc=albeu@free.fr \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®