From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965063AbdEKOoI (ORCPT ); Thu, 11 May 2017 10:44:08 -0400 Received: from mout.web.de ([212.227.15.4]:50676 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935291AbdEKOXv (ORCPT ); Thu, 11 May 2017 10:23:51 -0400 To: linux-metag@vger.kernel.org, James Hogan Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] metag-TCM: Delete an error message for a failed memory allocation in tcm_add_region() Message-ID: <39aa4ad5-ba12-ee30-1ca9-8699acde521b@users.sourceforge.net> Date: Thu, 11 May 2017 16:23:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:5bsmptNZx4hBq2H+ce9OMkwFLOsB+LJnIc56YKU5DOxo0+5dN9T ABtV1RuDg56KSAr3KSRnO4WSWb6ATw0qGrdpIG5ie1ABseTCBbYkxTknImG0vri/gI76pFY n1qeU6kl99xDMECOq2V+APmUH60Uw4yzODX2nxxrV+8+Pp4VGMBog1fV7Tr6/uOceHUUeO/ fGrfcRGGtYwOf7OM4D4pQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:VGaiO210QW0=:bwQp0EPJwGKD42/SuEPwOL qbg3jhUBbGH8urNq7kkB8DeV9LkVibDSB3LGX1/Kk0Xiu3l77PdLC+cyzzPHJnuKtF4WqdifU /LcZ/PyFt2gd8rWTO5uk+uIt6TUYHTQSab0nLj1R/d04TGIlr08NpmX+/B9fsImVIfB0B7Tpj uXa5R/3ftdz+A3I0DNeV2eOadbi19ScP8HCsxOGwz5lxGUEdOhnIHQHBrWGLbQt3OLy6kMS5G Dyum04rg0V1VFlr6YMXOq4wGZSs9ZNeIZcDYCRZLy9oFACbBqKgF/nlrLsWIEprc8JDrdJuMT sl/AiQKRCk5pEyjJ9rHMsX9yjy/FmG8aG3Qxg5/S8gaBMrWZCctOv/y4csWATlQ8vJyZsqCeN G914CqXscqG1NVhZWbgKvf+V5epUm6fqY3pwhrw/e4gliE1pzhxYYdd6MmZBLlsxxa77uZ90M YY9/3xkXo+GPwbNf56gkPQge+32jKWQcAmjWROYy4Ox8rJ+ISRpXoF73FAQ2UkrnuyS6HLPcW /YnENBWRoSIvh8Z414b+DS4QZnk+8g18CzvB2BSNB/lUul/pDxqahoa0afaeKg5nHsp1rWSzw 5KITzq1Sgh9DaGPXQ5BHq4Ud/3i3vcKRy20vkmQwLbRi4X9v9OG4zCjB43X6idNmYhdz8/D+B mvFHwSivjh7PygmjilqHY4ekkM8lBrLQ6VCsdhBNil8zQsUGCVm1UcE8ELRnofA8+Oo3vyP0F zDqNZlPOyjKZQmG+1BwOymaS0zabZIBHvoSQqNNJfTaEFH52UswxvSkdSGUhCd97XQXMYl5dd B0+//9M Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 11 May 2017 16:16:32 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/metag/kernel/tcm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/metag/kernel/tcm.c b/arch/metag/kernel/tcm.c index 5d102b31ce84..6c9985591cf1 100644 --- a/arch/metag/kernel/tcm.c +++ b/arch/metag/kernel/tcm.c @@ -115,10 +115,8 @@ int __init tcm_add_region(struct tcm_region *reg) struct tcm_pool *pool; pool = kmalloc(sizeof(*pool), GFP_KERNEL); - if (!pool) { - pr_err("Failed to alloc memory for TCM pool!\n"); + if (!pool) return -ENOMEM; - } pool->tag = reg->tag; pool->start = reg->res.start; -- 2.12.3