mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
	Linus Walleij	 <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski	 <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski	 <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	 letux-kernel@openphoenux.org
Subject: Re: [PATCH v4 6/7] pinctrl: ingenic: Handle X2600 Port E Schmitt trigger
Date: Thu, 19 Nov 2026 11:00:53 +0100	[thread overview]
Message-ID: <39af3ec5a953dcc1cbada1c53881f8361f63e80e.camel@crapouillou.net> (raw)
In-Reply-To: <1932f6b68d67badeddcd1d1ec213d2918d877d71.1795022736.git.hns@goldelico.com>

Hi Nikolaus,

Le mercredi 18 novembre 2026 à 18:25 +0100, H. Nikolaus Schaller a écrit :
> Port E has two Schmitt trigger configuration bits per pin.
> Select the lower-hysteresis mode when enabling and read both bits
> to report firmware-initialized settings.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-
> ingenic.c
> index 02ebfecf9563a..876e8e9e00c45 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -69,6 +69,7 @@
>  #define X2000_GPIO_PEPD				0x90
>  #define X2000_GPIO_SR				0xd0
>  #define X2000_GPIO_SMT				0xe0
> +#define X2600_GPIO_SMT1				0x100
>  
>  #define X2600_GPIO_SHADOW_OFFSET		0x800
>  #define X2600_GPIO_PAGLD			(X2600_GPIO_SHADOW_OFFSET +
> 0xf0)
> @@ -4697,6 +4698,9 @@ static int ingenic_pinconf_get(struct pinctrl_dev
> *pctldev,
>  			return -EINVAL;
>  
>  		arg = !!ingenic_get_pin_config(jzpc, pin, reg);
> +		if (is_soc(jzpc, ID_X2600) && offt == 4)
> +			arg |= !!ingenic_get_pin_config(jzpc, pin,
> +						X2600_GPIO_SMT1);

You mis-align it here, then fix it in patch [7/7] in a somewhat unrelated patch.

Honestly, you can keep it on one line - the hard limit is 100 chars per line
now, and splitting here does not make the code more readable, on the contrary.

>  		break;
>  
>  	case PIN_CONFIG_SLEW_RATE:
> @@ -4771,6 +4775,11 @@ static void ingenic_set_bias(struct ingenic_pinctrl
> *jzpc,
>  static void ingenic_set_schmitt_trigger(struct ingenic_pinctrl *jzpc,
>  		unsigned int pin, bool enable)
>  {
> +	/* Port E uses two bits; select the lower-hysteresis Schmitt mode. */
> +	if (is_soc(jzpc, ID_X2600) &&
> +	    pin / PINS_PER_GPIO_CHIP == 4)

Same here, no need to split.

Cheers,
-Paul

> +		ingenic_config_pin(jzpc, pin, X2600_GPIO_SMT1, false);
> +
>  	if (is_soc_or_above(jzpc, ID_X2000))
>  		ingenic_config_pin(jzpc, pin, X2000_GPIO_SMT, enable);
>  	else

  reply	other threads:[~2026-11-19 10:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:25 [PATCH v4 0/7] pinctrl: ingenic: Add X2600 support H. Nikolaus Schaller
2026-11-18 17:25 ` [PATCH v4 1/7] pinctrl: ingenic: Swap ID_X1600 and ID_X1830 H. Nikolaus Schaller
2026-11-18 17:25 ` [PATCH v4 2/7] pinctrl: ingenic: Fix hardware dual-edge interrupts on X1600 H. Nikolaus Schaller
2026-11-19  9:33   ` Paul Cercueil
2026-11-18 17:25 ` [PATCH v4 3/7] dt-bindings: pinctrl: ingenic: Add X2600 support H. Nikolaus Schaller
2026-11-18 17:25 ` [PATCH v4 4/7] pinctrl: ingenic: Add X2600 register and GPIO IRQ support H. Nikolaus Schaller
2026-11-19  9:52   ` Paul Cercueil
2026-11-19  9:59     ` H. Nikolaus Schaller
2026-11-18 17:25 ` [PATCH v4 5/7] pinctrl: ingenic: Add X2600 pin groups and functions H. Nikolaus Schaller
2026-11-19 10:11   ` Paul Cercueil
2026-11-18 17:25 ` [PATCH v4 6/7] pinctrl: ingenic: Handle X2600 Port E Schmitt trigger H. Nikolaus Schaller
2026-11-19 10:00   ` Paul Cercueil [this message]
2026-11-19 10:11     ` H. Nikolaus Schaller
2026-11-18 17:25 ` [PATCH v4 7/7] pinctrl: ingenic: Handle X2600 Port E pull configuration H. Nikolaus Schaller
2026-11-19 10:04   ` Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39af3ec5a953dcc1cbada1c53881f8361f63e80e.camel@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=krzk+dt@kernel.org \
    --cc=letux-kernel@openphoenux.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®