From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Xilin Wu <sophon@radxa.com>, Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add reg and clocks for QoS configuration
Date: Fri, 15 May 2026 12:16:23 +0200 [thread overview]
Message-ID: <39b2311b-b3e3-42a7-a97c-fa190c9dabfb@oss.qualcomm.com> (raw)
In-Reply-To: <20260507-sc8280xp-qos-v1-3-15135858cd98@radxa.com>
On 5/7/26 4:25 PM, Xilin Wu wrote:
> Add register ranges for the SC8280XP interconnect providers so the driver
> can program the NoC QoS registers.
>
> Move the real NoC providers under soc@0, keep clk_virt and mc_virt as
> virtual top-level providers, and add the clocks required for QoS
> programming on aggre1_noc and aggre2_noc.
>
> Signed-off-by: Xilin Wu <sophon@radxa.com>
> ---
This looks good to me
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
+Odelu please check if the clocks are correct
Konrad
next prev parent reply other threads:[~2026-05-15 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 14:25 [PATCH 0/3] Enable QoS configuration on SC8280XP Xilin Wu
2026-05-07 14:25 ` [PATCH 1/3] dt-bindings: interconnect: qcom,sc8280xp-rpmh: Add reg and clocks for QoS Xilin Wu
2026-05-15 7:09 ` Krzysztof Kozlowski
2026-05-07 14:25 ` [PATCH 2/3] interconnect: qcom: sc8280xp: Enable QoS configuration Xilin Wu
2026-05-15 10:10 ` Konrad Dybcio
2026-05-15 10:25 ` Dmitry Baryshkov
2026-05-07 14:25 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add reg and clocks for " Xilin Wu
2026-05-15 10:16 ` Konrad Dybcio [this message]
2026-05-15 10:26 ` Dmitry Baryshkov
2026-07-07 3:21 ` (subset) [PATCH 0/3] Enable QoS configuration on SC8280XP Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b2311b-b3e3-42a7-a97c-fa190c9dabfb@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=odelu.kukatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sophon@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®