From: Ian Abbott <abbotti@mev.co.uk>
To: Jesse Chan <jc@linux.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE
Date: Mon, 20 Nov 2017 10:46:36 +0000 [thread overview]
Message-ID: <39b27702-cd33-2fbf-d57c-6f30fe7a28b3@mev.co.uk> (raw)
In-Reply-To: <dc2648b6-8dfc-afc9-8b11-e6e82b7ae125@mev.co.uk>
On 20/11/17 10:29, Ian Abbott wrote:
> On 20/11/17 07:50, Jesse Chan wrote:
>> This change resolves a new compile-time warning
>> when built as a loadable module:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in
>> drivers/staging/comedi/drivers/ni_atmio.o
>> see include/linux/module.h for more information
>>
>> This adds the license as "GPL", which matches the header of the file.
>>
>> MODULE_DESCRIPTION is also added.
>>
>> Signed-off-by: Jesse Chan <jc@linux.com>
>> ---
>> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
>> b/drivers/staging/comedi/drivers/ni_atmio.c
>> index 2d62a8c57332..b61d56367773 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
>> .detach = ni_atmio_detach,
>> };
>> module_comedi_driver(ni_atmio_driver);
>> +
>> +MODULE_DESCRIPTION("Comedi low-level driver");
>> +MODULE_LICENSE("GPL");
>
> Thanks! I wonder how I managed to miss out this driver in commit
> 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI
> modules")?
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Despite my above comment, we should probably give precedence to Matthew
Giassa's patch for the same issue, since it was sent earlier.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2017-11-20 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 7:02 [PATCH] " Jesse Chan
2017-11-20 7:12 ` Greg Kroah-Hartman
2017-11-20 7:50 ` [PATCH v2] " Jesse Chan
2017-11-20 10:29 ` Ian Abbott
2017-11-20 10:46 ` Ian Abbott [this message]
2017-11-22 7:04 ` Matthew Giassa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b27702-cd33-2fbf-d57c-6f30fe7a28b3@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jc@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®