From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D2C2E9746 for ; Mon, 8 Sep 2025 07:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757317007; cv=none; b=nNHkWGTkkzidIpyAwX/Y+c9LKSWKSnsrt+tOsX+O1ld45y4yclANYPNUvPdu8A6bHkBTEYefphXg4erdnlaBc0o2yNYOdrq03gTiEWdF+XqWxgWh9v4xUtNmOpCBEKu8N590TWIR8w0PNje4ywK/IfAunPQz9oyMbQMAB44azIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757317007; c=relaxed/simple; bh=zXHMUEdWc0BlUDHaEPySSzugxui2LIQJINaYGqG6S28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jsyji9jwSwK93dEOLjdFN/te5HnPzLgnpY725vfKvGDpdU9I5wsVN321+Tsh0/ZEA6xhGaJ4VorJpnVR+1HxyUZyjTOqPN7hROihlhWc2UGMd1P3xOrj/6vSZDClhVW1mpbmylJ7KheFRewOwSIwrvsfLIMNVKD0Gvkka61UBzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oqUr7NDg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oqUr7NDg" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 587MP5Xx028233 for ; Mon, 8 Sep 2025 07:36:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QNHN7kPRAWt4JfWXRnbbHXUE90qzcsGnkDRXHKAjBCg=; b=oqUr7NDgdpeIBem0 aVox1B+2FjDGu1UOiC+yVMM1C7o+lWzGABi2XQTC6PuSwD1aa2x84C/Up62MXDgr 84rDBjaseTB2FQmtL/pQZ4Etmaeum3x6jPtyIdbZnuDBZEnSSzTbbulP6R1BhBtw wanMFBO495a7SYeTSOUdp4N55V5C9eXS6Ey8VxvFoNVlTkmTb+8Aqss7G8fg9i7T o/98QkYuf0veFhKAcVDsQ3qNubCwoAbDG+pYXqh+PKjhg4E5JqK7S39sy7fQ8y3L xrS7OIB+9K/2IzmKuRLpDdSIXe0WN9CxSoPjSiXvL4uS7YOZaa4YimVzrR8yC/up raSUUQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490c9j3qmp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 08 Sep 2025 07:36:44 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b33e296278so7500611cf.0 for ; Mon, 08 Sep 2025 00:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757317004; x=1757921804; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QNHN7kPRAWt4JfWXRnbbHXUE90qzcsGnkDRXHKAjBCg=; b=Feg2t62/bbIhuXYFJeGY/gesz8ukjU+WcCTDgN+HOxcJtu36dqQsUjtJVdHFfVgQXF af67yyv1sjlJTp0FL1t6a9oJlI1VAM1Egx7LSHB1HvYQot2+YQCgj3kvES135oFJ+Vz0 b9bqfDrefCczrFV+U4ienV0/iBZvWzHzYV/pysZIsp28o/RkyrZK3S69GA4eCgvTS1EQ FMyvxIyP11Mq9WpT6XguiWpPeCdami+RmZeyDIV5qdUFnPDsPcP4kASucxZ9g+e+6wOU 1EwvNiu9Ly4mAew5gz9LkEsGBovV9Ai78qhiWfuFFHKy9IJVIxNdFZBwIIUqgItCvpzE x+vA== X-Forwarded-Encrypted: i=1; AJvYcCWP3TD7u9owndNg6rUcaNBWnKvlazV2zXzMVlbI/ujCeIdFnB0nHErMJ/1qP1RIp+Dvdv8LdRmmUr2pbXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5m7egun2A3k06zTxL/MvlnezPMFfIvtibqDcZJKtsPx1pBYUj FlvKZVDASw3lXexMlO00YBmsgM0Ass43nX3sk9/eKC/SiE0FsJfV6nefi3tGRahtr5j6j9YLzc7 eGVUEQwJLsy8Qmf9kcToLSuT60lii3L1LwD3fsOCxCOa4RhQxrS/1NlihOzUKn7IGyZE= X-Gm-Gg: ASbGnctkGaRLL2+LTCLC6kBc1zIlbjGqxWinpaONKAEieF02EcHKdpr004NiKMdMbYH cHSjB+tq3YMH4RSddpjkwTq8r91TJ/fawtDeOU6MJRTOhPIzdO6ZfVJNxSqx0fkkcb5WaKtN+si s2fgnCJDkIEI/G5719aDT4GRQiFD0dHwsDaSjSD8ZTcfQ2ZuPlzzeZdZf8onLdAJLYtrxrSHqWu jZp00WsyUTPFPoFgm8P3u0UVHKNiFNpmXADiV1IUtLat+YP5nu0krT3UqJDfIwqG61Ujdob+KZQ Xe+hr/4xeZcY0dB6nkc23o+laDFf3FGLfkWUPeXK105o9RoGY6hB9dy4H+WKPJKewu+eeQS/Ep/ 0A/kEz5WvLWjQnV+BYsSNhg== X-Received: by 2002:a05:622a:1787:b0:4b3:4590:ab6d with SMTP id d75a77b69052e-4b5f848d05bmr48274151cf.7.1757317003660; Mon, 08 Sep 2025 00:36:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElIxN4NWUvxQroVKmxTi8+UW7BRi0pLtgjjPwqySqL6k7dbcrx49kS4O8YknoB23Bc/E9voA== X-Received: by 2002:a05:622a:1787:b0:4b3:4590:ab6d with SMTP id d75a77b69052e-4b5f848d05bmr48273961cf.7.1757317002960; Mon, 08 Sep 2025 00:36:42 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b0484e8a4a1sm1001949866b.83.2025.09.08.00.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Sep 2025 00:36:42 -0700 (PDT) Message-ID: <39b955b9-a152-458a-8e09-908efebaaccd@oss.qualcomm.com> Date: Mon, 8 Sep 2025 09:36:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property To: Hans de Goede , Aleksandrs Vinarskis , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Daniel Thompson , Jingoo Han , Mauro Carvalho Chehab , Jean-Jacques Hiblot , Jacopo Mondi , Sakari Ailus , Bjorn Andersson , Konrad Dybcio Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250908-leds-v3-0-5944dc400668@vinarskis.com> <20250908-leds-v3-2-5944dc400668@vinarskis.com> <0e030e7d-0a1a-4a00-ba18-ed26107d07fa@oss.qualcomm.com> <046b289d-b6a5-45f9-88b1-090e2ab7c95d@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <046b289d-b6a5-45f9-88b1-090e2ab7c95d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAyMiBTYWx0ZWRfX/NeJ5K/ubgUI XbyEv/aMHZbfdaFRLyB7Po156ISxvY4NSorW2ZDrqo4sNreIBlpZB4b0a3u7baDt7j2LRsC+BUt mOTIPxpusoc/F/zlTlud5o56X1Q6RwxPXHUxXj6xmDmKUjl+PyKsjAg6I8X+f5hVJbZmEveLI+8 Pnr8v4SaQMeqHFe1Ae+nsIarqNwj8DdGkGO+yl3VlgqwSx/KcoargoH4ZTeFBW6auojoP+XuZIi pmcYz19+NayY+tROGBKoT6YsJQS5I4zn05JiC8sEv0I5HqG21NZuUWRWrX4Orm4GIF1Iy98zMbI Fd9ZeWjBLRC+N6b7NSE0BbYn3EUTwwH5xW4Li1B5tOIqGnyaDSNCz9xAKdcK/k8+x6GpScY4A9T h+pQLsn8 X-Proofpoint-ORIG-GUID: GFfuC1iBObvHLQrt2MK1BhtxBve7HRxs X-Authority-Analysis: v=2.4 cv=PpOTbxM3 c=1 sm=1 tr=0 ts=68be878c cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=I76Qk8w-AAAA:8 a=wJ-R-PlTzkls_HvLT0IA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=vUPM0Wvl0xcrLs4nqPIT:22 X-Proofpoint-GUID: GFfuC1iBObvHLQrt2MK1BhtxBve7HRxs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-08_02,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060022 On 9/8/25 9:33 AM, Hans de Goede wrote: > Hi, > > On 8-Sep-25 09:20, Konrad Dybcio wrote: >> On 9/8/25 1:18 AM, Aleksandrs Vinarskis wrote: >>> A number of existing schemas use 'leds' property to provide >>> phandle-array of LED(s) to the consumer. Additionally, with the >>> upcoming privacy-led support in device-tree, v4l2 subnode could be a >>> LED consumer, meaning that all camera sensors should support 'leds' >>> and 'led-names' property via common 'video-interface-devices.yaml'. >>> >>> To avoid dublication, commonize 'leds' property from existing schemas >>> to newly introduced 'led-consumer.yaml'. >>> >>> Signed-off-by: Aleksandrs Vinarskis >>> --- >> >> [...] >> >>> >>> + leds: >>> + minItems: 1 >>> + maxItems: 1 >> >> My brain compiler suggests this will throw a warning (minItems should >> be redundant in this case) >>> + >>> + led-names: >>> + enum: >>> + - privacy-led >> >> Nit: "privacy" makes more sense without the suffix, as we inherently >> know this is supposed to be an LED > > Note "privacy-led" as name is already used on the x86/ACPI side and > the code consuming this will be shared. > > With that said if there is a strong preference for going with just > "privacy" the x86 side can be adjusted since the provider-info is > generated through a LED lookup table on the x86/ACPI side. So we can > just modify both the lookup table generation as well as the already > existing led_get(dev, "privacy-led") call to use just "privacy" > without problems. In that case, it may be cleaner to just go with what we have today (unless the dt maintainers have stronger opinions) Konrad