mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sohil Mehta <sohil.mehta@intel.com>
To: Hamdy Abou El Anein <info@daylightlinux.ch>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hamdy.aea@protonmail.com" <hamdy.aea@protonmail.com>
Subject: Re: [PATCH] scripts/x86/intel: keep the highest microcode revision
Date: Fri, 13 Nov 2026 18:46:03 -0800	[thread overview]
Message-ID: <39bc7f0e-205b-49a6-9bd3-d23e976cb30b@intel.com> (raw)
In-Reply-To: <20261107191356.151287-1-info@daylightlinux.ch>

On 11/7/2026 11:13 AM, Hamdy Abou El Anein wrote:
> From: Hamdy Abou El Anein <hamdy.aea@protonmail.com>
> 
> Ucode equality ignores the revision, so adding entries to a set keeps
> the first revision seen for a CPU identity and platform mask. When
> multiple input files contain different revisions of the same microcode,
> the generated old-microcode thresholds depend on their order.
> 

This is by design. The current script assumes only a single release is
used for generating the output.

https://lore.kernel.org/all/5e3dc792-c5aa-4024-b2a3-32db49da8132@intel.com/

Do you have a need where multiple directories need to be combined?

Also, sometimes newer releases remove entries or roll them back (in
exceptional cases like microcode-20260812). So combining releases to get
the highest value isn't always desirable.


> For example, passing the 06-8f-08 blobs from microcode-20250512 before
> microcode-20250812 keeps 0x2b000639 and 0x2c0003f7 instead of the newer
> 0x2b000643 and 0x2c000401. Reversing the inputs selects the newer values.
> 

> Keep entries in a dictionary keyed by the same CPU identity and platform
> mask, and replace an entry when a higher revision is found. Preserve
> the existing output ordering and debug-revision rejection.
> 

      reply	other threads:[~2026-11-14  2:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 19:13 Hamdy Abou El Anein
2026-11-14  2:46 ` Sohil Mehta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39bc7f0e-205b-49a6-9bd3-d23e976cb30b@intel.com \
    --to=sohil.mehta@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hamdy.aea@protonmail.com \
    --cc=info@daylightlinux.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®