From: Bing Bu Cao <bingbu.cao@linux.intel.com>
To: kieran.bingham+renesas@ideasonboard.com,
Rajmohan Mani <rajmohan.mani@intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
Tian Shu Qiu <tian.shu.qiu@intel.com>,
Jian Xu Zheng <jian.xu.zheng@intel.com>
Cc: tfiga@chromium.org
Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
Date: Thu, 11 Oct 2018 17:53:45 +0800 [thread overview]
Message-ID: <39c26dd4-4454-f557-f510-ae973f5d9c89@linux.intel.com> (raw)
In-Reply-To: <33c53caf-633a-f359-4312-9c2dc317efc5@ideasonboard.com>
On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> Hi Rajmohan
>
> Thank you for the patch,
>
> On 10/10/18 00:42, Rajmohan Mani wrote:
>> Removed redundant CIO2_IMAGE_MAX_* definitions
>>
>> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
>>
>> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Looks like this {sh,c}ould be bundled in with
> "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration.
Raj and Sakari, I think this change could be bundled into the Trivial
patch sets, what do you think?
>
> --
> Regards
>
> Kieran Bingham
>
>> ---
>> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> index 240635be7a31..7caab9b8c2b9 100644
>> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> @@ -10,8 +10,6 @@
>> #define CIO2_PCI_ID 0x9d32
>> #define CIO2_PCI_BAR 0
>> #define CIO2_DMA_MASK DMA_BIT_MASK(39)
>> -#define CIO2_IMAGE_MAX_WIDTH 4224
>> -#define CIO2_IMAGE_MAX_LENGTH 3136
>>
>> #define CIO2_IMAGE_MAX_WIDTH 4224
>> #define CIO2_IMAGE_MAX_LENGTH 3136
>>
>
next prev parent reply other threads:[~2018-10-11 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 23:42 Rajmohan Mani
2018-10-11 9:33 ` Kieran Bingham
2018-10-11 9:53 ` Bing Bu Cao [this message]
2018-10-12 19:00 ` Mani, Rajmohan
2018-10-13 21:01 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39c26dd4-4454-f557-f510-ae973f5d9c89@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=jian.xu.zheng@intel.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®