From: Markus Elfring <Markus.Elfring@web.de>
To: patchwork-bot+netdevbpf@kernel.org, vulab@iscas.ac.cn,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH] net: qrtr: fix node refcount leak on ctrl packet alloc failure
Date: Tue, 2 Jun 2026 20:52:16 +0200 [thread overview]
Message-ID: <39c49c28-0674-43a2-8048-6687f9a3bace@web.de> (raw)
In-Reply-To: <178036982189.224606.10962942847177813465.git-patchwork-notify@kernel.org>
…
> > Add qrtr_node_release(node) before returning on the allocation failure
> > path to properly release the reference.
…
> Here is the summary with links:
> - net: qrtr: fix node refcount leak on ctrl packet alloc failure
> https://git.kernel.org/netdev/net-next/c/3b09ff541145
Would it have been possible to avoid a bit of duplicate source code
by using an additional label in the implementation of the function “qrtr_send_resume_tx”?
https://elixir.bootlin.com/linux/v7.1-rc6/source/net/qrtr/af_qrtr.c#L998-L1024
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.1-rc6#n526
Regards,
Markus
prev parent reply other threads:[~2026-06-02 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 8:00 Wentao Liang
2026-05-28 14:33 ` Alexander Lobakin
2026-05-29 17:38 ` Manivannan Sadhasivam
2026-06-02 3:10 ` patchwork-bot+netdevbpf
2026-06-02 18:52 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39c49c28-0674-43a2-8048-6687f9a3bace@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®