From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0ECB32AAB5 for ; Thu, 21 May 2026 08:28:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352133; cv=none; b=Ik8B5isf/ra8745fKrXyMLvte2n38SiWnSGtQbvtMMGad4/kjT5QXkNm9vaq8ofDItH2AzwH3QU1izX87bByuMeFAtFQTFddQ23IX0nGTJSFos8YCC6yA90bt/33Z3uK/Ntoo7mBvmBK7dre84hp6oCB0ZLVFSNI8X1TGha90s4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352133; c=relaxed/simple; bh=JCKBc92lllO+Vg8o7We+zPzUPXWN4KaH2X6Zxw9ezyU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=mayMbApUSt/BKCyvIrpYncLp/TI84h64VlkNGgVTjPfuUHQRKPcrdb8bqIiOPJnZg11f8T7oJ66c+OIZJmFZp2STrO5W8vKDe7tpFnyHOLHivG01aXZxrNm2wDKBfNNYk3NCscXwjXz2k2QPAX+VsAzvNN0OT/92M+6GmOLrTKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B+bGLX7r; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B+bGLX7r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50CB11F00A3B; Thu, 21 May 2026 08:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779352131; bh=Wu+0kykA399VXJw5UWaA7tdCksypV+KBAuwE/U9Dt70=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=B+bGLX7r3N+n4X88nfCJ/JmbeLDFWXCkrJUAFySYGS3mzLlvdZKHrdvT91tkJKXDb i1hBF4UQu7MPePxQUgQA5poclydGCIGFJw1K5yUhG5iSbVGL/QcpniOG38lqzkZ01t PMyugch4OPjIO2Nk6Lgouta7Erv6mGwry+7Hxn5+N/msoMb+/ve2bCRCXLZpI7pg+B IGIdQthQ/P4h2YGn9zT/PZP8hoND/9TZLP1zKXGBTGBWkvNfBX/qQELj/fHth1VNac I6JLrX7wSofdzyHzANAfEWxn6Ib79bqR4CMXD0Fq1hB5JLkdvRdkdXRdyjmxSGw/X/ YrhEiMmjwJFQQ== Message-ID: <39c59d05-c998-456a-afae-1eee7379a04c@kernel.org> Date: Thu, 21 May 2026 16:28:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH] f2fs: fix missing read bio submission on large folio error To: Wenjie Qi , jaegeuk@kernel.org References: <20260520095204.1175117-1-qwjhust@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260520095204.1175117-1-qwjhust@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/20/26 17:52, Wenjie Qi wrote: > From: Wenjie Qi > > f2fs_read_data_large_folio() can keep a read bio across multiple > readahead folios. If a later folio hits an error before any of its > blocks are added to the bio, folio_in_bio is false and the current error > path returns immediately after ending that folio. > > This can leave the bio accumulated for earlier folios unsubmitted. Those > folios then never receive read completion, and readers can wait > indefinitely on the locked folios. > > Route errors through the common out path so any pending bio is submitted > before returning. Stop consuming more readahead folios once an error is > seen, and only wait on and clear the current folio when it was actually > added to the bio. > Cc: stable@kernel.org > Fixes: a5d8b9d94e18 ("f2fs: fix to unlock folio in f2fs_read_data_large_folio()") > Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu BTW, I can not apply the patch, can you please rebase it to last dev branch? Thanks,