From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D651C391E5D for ; Tue, 10 Mar 2026 14:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151964; cv=none; b=O/2U+uN3I2bOYnvhapXMdIBZg6It2kttDDzqbxyqxfjS6Yk0gkf8CGFzIkajsKN2l+OwXKF3pP6YRKaJgujKUGKC2cKpHVo3Sz47luLcPnTIWRoxK30lPh2vFfw/e2WrMtp2btDGQGyHnh5iIWZbvg/3+MTthqD1j9qQyq79WsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151964; c=relaxed/simple; bh=+0QsUmKSdIAOx3H5r3Bwuurcl+aY3MLfHPpoPquchN8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WYNNcK7oIy9h3L3+RUlOaDhUnD3Fr9AwQ87E1M0xTR/2+mg6IMzJ85TrEbOo3y1PQ3CUKKLItd2x7gwEFLeuxciUxw91FbMJFV5FkR8vE2DiDmqw0XcG6bb60qLsFBQYDD/U0xEi9F+a9lxZaDEvx0wlJuXQXl2PbTcCTO2z3a0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YsQM/M47; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PosIlbpU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YsQM/M47"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PosIlbpU" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACavYR3296707 for ; Tue, 10 Mar 2026 14:12:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wyF4wZYpsxMauFewTjHkjZxZN1aE7LqB8yEQANT66m4=; b=YsQM/M47A/tVFFWU TM3WoFHx2VfZxVGNJ2syTUVR+okXmuEny/juQEf8fwZ3pMnw2JikAFHjIaw8x+H/ Q7QoYcN+IeUBHe359Gze6tYv6DatTqwFMM2NcZ9E4F5S7tWpo7ClYkMCjoYCG3bx w5LSrBMI6MDohr53VeXxQYckcDQHLV48mv8AwUEBdO/aRM9Ri3kpxMwI1usajMj/ qMeNTr/GdW9JNVn4KVxgt6P7LZaWXCOTQWTImoSSbTa9z4jlw8sSNMlX+MgG4FAU qI2dmsuMWWOzmosed3GVpB2XN4VLp6txp5TzstSYu24qczggWf/rztznjEyjdtEu wIX7iw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctg1ms7b1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 14:12:41 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-5ffd797184eso798648137.3 for ; Tue, 10 Mar 2026 07:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773151961; x=1773756761; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wyF4wZYpsxMauFewTjHkjZxZN1aE7LqB8yEQANT66m4=; b=PosIlbpUDbfhKzXBSfF3QnZOmghopL0UuJWY0vLV/jjp64SohguqNm5dJEYqnhU+Cq Xcj0G/hhU2gnCzaAfylNyMVaXDg2S6qSLlT1ZhOhHP9Hbmov2iBi/3koNr3yfY0mg2Tp gKepIoSF4Y9wcjERWZKSH3TrjIYuRLWfkGv3+BJTNlxPK+mk6Ou5MMLHMDAambuqm/7X 76Fic9/kr0miIPUhh2JLHKoDoHv9SRQvBCqmIVb3bSelhx6hofmlwTMa0HUgTLdkS3sR HCVklECPAoLSPther5cYG2SQKZHSrmk3qciJ8Zc0/fw75RINVpTrCZGfm7j6q885K57b kCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773151961; x=1773756761; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wyF4wZYpsxMauFewTjHkjZxZN1aE7LqB8yEQANT66m4=; b=evyrI2rZDuruxztscyPtG0M17Q86107ysf3ECP3jPPpWTl2WKfORwYTSojuhKfPJYg De9NMg7/yrcA4bC83nmA7/3a1pkeetzAC9FNG34KFTSJ3PaaYRyH85MSUDFJsaYEthZ4 uGV9yZkK/qKvxp4l1wjXsAv4fRn8cV/hPy7IW5u1LWHxi83ayIfFvwZDVng+p4lxXLQz JCOJLV1EFHiiTgm6rUH3WmNztbKsDoe5VGW1uAsqEqfl2FZlQeG0l33jrn2hti0RouhA zkxWP+6rRS3kr8v4IFKVFbVpP03B/zhjdRGOxiagGfMFgDcysujsXBH6Lu0+3iICoufg 0Btw== X-Forwarded-Encrypted: i=1; AJvYcCVf24slypHrcJEUfRP1Lta9/5x0QswLrewg72l21RnFJjKIWmVaaVPF1Ma/WvkW0+qqx8OKYBI1UitmZxs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7g0bhUV0DXwIwSdRNEsMH0jTLWPV2Lzr8Sg3N2a0EZMLOy10J NAZ7XXSGPY62hZL1TmL6Mla1f9878PncNoLrlmXCU73h8r62M1z2oFGnxvEkNUiuxwBiw/v630d rI5WCs6gJoideAwnrlZiTZow1mVZbjhP+CufYJzjtuvyueRowoUzF2iNG/5n/vFRyjOc= X-Gm-Gg: ATEYQzzCffGtquFxaPIHS0Y0FWe0lyu0DuJF0eIebn6r7CgqpgU+ZAJggkwfRNJ5GTv DBS3VubjUlRtUdYkRwAV8WywhGPnzJzv2NXY2BJ3C8rcv4MZHukBFhx8ZjZRhYbUIuzAm+iwcTn sYT23mqCJkdW1TkFsA3cyTnfZFZcAE/3+XeJZ1094N3yDSKZ7/Hu+ZNHHYPRIjcO7f2JT3IY534 LICT+uRWZWSlEnWGFC3WEdvYK7mPtfY0FUCEyLGw4z04bSO7uJboejOFWVXww1H6fquCCQ972cH m2INbFPyTCvrgkZYriCV/X821m8isbztvBFUkRvcjg50C6HI48157wLyTgBmS2xCDoOGBkyLJpm pUALvlC4kKRLurgvu1vThrM3Ehj5mBbx5jp7EnMkPmvCZ4qmdfLmVBCvgbnitdCuRCwa/5bcFZR 5d6dw= X-Received: by 2002:a05:6102:32c1:b0:5ff:a16b:93e2 with SMTP id ada2fe7eead31-5ffe5e9712bmr2763521137.2.1773151961096; Tue, 10 Mar 2026 07:12:41 -0700 (PDT) X-Received: by 2002:a05:6102:32c1:b0:5ff:a16b:93e2 with SMTP id ada2fe7eead31-5ffe5e9712bmr2763489137.2.1773151960520; Tue, 10 Mar 2026 07:12:40 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a3c66d3fsm4317323a12.2.2026.03.10.07.12.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 07:12:39 -0700 (PDT) Message-ID: <39c6d1de-53d7-4aab-b054-067c182fe0c0@oss.qualcomm.com> Date: Tue, 10 Mar 2026 15:12:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/11] arm64: dts: qcom: monaco: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-4-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-4-b9c2a5471d9e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=YOeSCBGx c=1 sm=1 tr=0 ts=69b026d9 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=z_dnvKGLtVwtNw_c-ccA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-ORIG-GUID: KS4DWYz49Bk6QvGbf3_waSf3jzGVp_dl X-Proofpoint-GUID: KS4DWYz49Bk6QvGbf3_waSf3jzGVp_dl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEyNCBTYWx0ZWRfX1GtCJeGhTWlg 4G7G2EA6aNCE5JbPOTlfCMqzvbN6cROxzawUEhZcirBotHcMNPe3oMXfmjB4lgoFcjvNvbRhDkk Mkmp8D1w/r+48SNaBjAwf4pUx9D7dBbjX+ig+/jOzTprArBuzme4CwmSj4Qt5pf79wp/qdloKmE yNYPBb9m38D4PfgwQKziqVsiBsHYjTgjPi43RqyFuKBrGFKM4ApeXgexU5maDVuPGNYz0YWGOpc rMiNap5JOQIrA7FtEHNVqL04T3Te5c4H2C+mfxSbCQK4ILsS1J9xI85ht4GOyZIxMFBpVMWfd7K hZXFCgdVxfhnJyW6Hw6AILuk4ADwAPjgq5fNqrirNH6B0ynQt7AD4pWpibpu/Qq/O2xLYtjGDeG 39TCYaJmAo0FSe8KOvgN8E30OI6GFK2lTsvrtV7JTamsyRrRtrevCni+mwrwMDQzkI37GVW/+v+ UEkFUazsN008VT7qVtA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100124 On 3/10/26 9:06 AM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the > GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for > monaco. > > Fixes: cc9d29aad876d ("arm64: dts: qcom: qcs8300: enable the inline crypto engine") > Signed-off-by: Harshal Dev > --- Reviewed-by: Konrad Dybcio Konrad