From: Markus Reichl <m.reichl@fivetechno.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Minas Harutyunyan <hminas@synopsys.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jules Maselbas <jmaselbas@kalray.eu>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
Date: Tue, 7 May 2019 10:12:17 +0200 [thread overview]
Message-ID: <39c7b687-449e-5e89-4c70-527d4e779fd9@fivetechno.de> (raw)
In-Reply-To: <20190506130046.20898-1-m.szyprowski@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 2137 bytes --]
Hi Marek,
your patch did not help on stable v5.1
[ 3.255963] samsung-usb2-phy 125b0000.exynos-usbphy: 125b0000.exynos-usbphy supply vbus not found, using dummy regulator
[ 4.044547] usbcore: registered new interface driver smsc95xx
[ 4.112261] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.01
[ 4.120363] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[ 4.127560] usb usb1: Product: EHCI Host Controller
[ 4.132415] usb usb1: Manufacturer: Linux 5.1.0-00005-geb4efae48eb5 ehci_hcd
[ 4.139446] usb usb1: SerialNumber: 12580000.ehci
[ 4.183056] usb3503 0-0008: switched to HUB mode
[ 4.183121] usb3503 0-0008: usb3503_probe: probed in hub mode
[ 4.488344] usb 1-2: new high-speed USB device number 2 using exynos-ehci
[ 4.675605] usb 1-2: New USB device found, idVendor=0424, idProduct=3503, bcdDevice=a1.a0
[ 4.678166] usb 1-2: New USB device strings: Mfr=0, Product=0, SerialNumber=0
[ 4.686140] usb 1-2: skipping disabled interface 0
root@odroid-x2:~# lsusb
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Am 06.05.19 um 15:00 schrieb Marek Szyprowski:
> Samsung Exynos SoCs require to force UTMI width to 8bit, otherwise the
> host side of the shared USB2 PHY doesn't work.
>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with phy_utmi_width")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 6900eea57526..9ece4affb9d4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -76,6 +76,7 @@ static void dwc2_set_s3c6400_params(struct dwc2_hsotg *hsotg)
> struct dwc2_core_params *p = &hsotg->params;
>
> p->power_down = 0;
> + p->phy_utmi_width = 8;
> }
>
> static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
>
Gruß,
--
Markus Reichl
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2019-05-07 8:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 20:49 [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Krzysztof Kozlowski
[not found] ` <CGME20190506130052eucas1p25afd4e15648e9efc6fd011e46081fbea@eucas1p2.samsung.com>
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
2019-05-06 13:40 ` Jules Maselbas
2019-05-07 6:22 ` Minas Harutyunyan
2019-05-07 8:12 ` Markus Reichl [this message]
2019-05-07 9:17 ` Marek Szyprowski
2019-05-07 12:03 ` Marek Szyprowski
2019-05-07 12:38 ` Markus Reichl
2019-06-05 8:57 ` Krzysztof Kozlowski
2019-05-07 6:21 ` [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Minas Harutyunyan
2019-05-07 6:43 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39c7b687-449e-5e89-4c70-527d4e779fd9@fivetechno.de \
--to=m.reichl@fivetechno.de \
--cc=b.zolnierkie@samsung.com \
--cc=felipe.balbi@linux.intel.com \
--cc=hminas@synopsys.com \
--cc=jmaselbas@kalray.eu \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome