From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9367366DA7 for ; Fri, 20 Feb 2026 19:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771614446; cv=none; b=u1A0VuAcRDLwQb9uF3MwjzerVEMsvxgMuPMS81xtTQbzmuW7feRNzlLZZIbwFuMo9bA5fYXKT/RG4QGQQPVn7ZHxDJoEYl/98j2cIQ5whpIyjYBGIuZuanQPrfGU13k77fv+V/F2+qyHNV/+7lq4S8C9orT6wis+oXE56v8vg30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771614446; c=relaxed/simple; bh=jR5mkU/Mplyt6BcphocKhqTbwA/7skAQk4w2kG3c7P4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cXHwbieazAoFPFNZUlkdcauSYA1wlMtk1+UAlwVDJQO9L/MqfVA3ZJEin0Di4TYNilirOMXf78PZ3r8P38j6NvaRG7rhp3XfZuiupw1r7XgW0DCNncw1tJhVeQN4iP3SGfzL8K2BUtrwhAGJG+GtpoGoobRBpwWzHzj+24USg+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ha18F6+E; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ha18F6+E" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43767807cf3so1797199f8f.1 for ; Fri, 20 Feb 2026 11:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771614443; x=1772219243; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aIYysQO98VqTcpcnjxQ9HD3CfclEuBh0khiFG9kEwR8=; b=Ha18F6+ECkFfjKIXUfBwC+MmYlKjLP9q1+O9mLl82G3MPsaFzMKDJreZYEmMhezlnp LmJVOpvVjU49a72abmZX1zRQLm3voWw3Xk8907L4o6Zc/8VblCFO7HkeAl7OI7oIiDV+ d748/FK5r+sBjSPQpbOEETJvAW1g82/2tvlYP2ADNesnMWF8yS9of7hCQV0CDwlItGDy u0IfoLbDrrfS696kbMwIMrWK9qEc077VE+xjCjfWH6Pk6Vv5FS7RAETaScRyy48JGQRB InhWT9NSNNaIeejIpVt5aoAorOB72dkYkWoqkoHGNuHsWF8nob/6GCAkffGSYPj6oV2O G0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771614443; x=1772219243; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aIYysQO98VqTcpcnjxQ9HD3CfclEuBh0khiFG9kEwR8=; b=HdoUuRddNS9haFCW23FYfeumDq7IHbJYiGVjnso8pdxVNnYg1jadm7tjz1UftR5cpb ffrf1HYkBdydtLdDJXbspa+wJrgTDlj4b4Q2R5FgshbbCAP11sm9lFxVAOIQeJgBGNeB 9F/H+U54de8LBIHE1/J4BUGnUeoJG9at4RWXuoYW7ZehrUsr0VbffrUitJPaDyzpdIMq MRLVRvhPCmG08vbMnjhvDFHEFia2EVTxJ+mZHw1DUMMgSuHe3Iwlbq4tFgPNQt3dTnXZ UJL9h2G/2wX5ngqAh0UO+13hmIHNGxduNZdMc2zgILxPgLNzFBsj1W9Agh5Y4ceFYi1o N+3A== X-Forwarded-Encrypted: i=1; AJvYcCXakFWo9c+exN+qznz6xmFsWhSQ3vZ03feuZSqeLSqK5o8EMofLYU7L3uLCmUT/ottWEhrfFEWTsLORco0=@vger.kernel.org X-Gm-Message-State: AOJu0YxA293Wpqm/qg/OFyoV41JWQrGUM/tk+V4sXSgspUFYSSz1EAiR vtsoYKDcD2b8OA86Zb8CDzooFslHHX+Tmyy9jb3cJXQcrU39595KxL5a X-Gm-Gg: AZuq6aJUhBxBH9E5i7w82DmZbECdqot0DFIT9BLBnYcUB2DTGrH+UPilJhWdTSRVTZb fNoGhx9Kt/wNnXg56fxD+92x/1UBXDQ5T9dmgEqyta8XB9aCPM+SxxfCczEoRdSvFzjlu/Oa/bI gfCYYwJyIW41YAKAy3vX/ZLrPpdGLHDamXOIojueaK7BUw+sbWMDHfzqMwSk0+Ntx8eOAS0lk4p 9JNaEc2QngADT3Su24tlXXfrY+is0YqmtPEFily6moQtFfzKtp6q6HcEJdCNQ969a2WYE9A5Gb7 E5xv6vLXUiprOKYnlUJ4n4b0iDQXgqzRERE/bh7scbwOg7Saejfnct3/PhcRsnsbv7k6zWEZgwY 4HlKTdEafvhx/MhR11DslUFScGrMP9T/oOKmSyxM+0K5a1mRFqDXT1E55z7xrWTiIG54mcIyve0 dkN3Ecu1w8T7dbbG9EI9G/+bIseqn6/rXvbA4ojletY2ZffJ+prqnsrHyRf0Pu1A4= X-Received: by 2002:a05:6000:2f83:b0:431:a0:7dea with SMTP id ffacd0b85a97d-4396f181aa5mr1830793f8f.40.1771614442895; Fri, 20 Feb 2026 11:07:22 -0800 (PST) Received: from [192.168.20.170] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00485sm83600f8f.9.2026.02.20.11.07.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Feb 2026 11:07:22 -0800 (PST) Message-ID: <39d36f25-abf6-41e1-8762-d9de38891a2b@gmail.com> Date: Fri, 20 Feb 2026 20:07:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: ehci-orion: remove optional PHY handling code remnants To: Miquel Raynal Cc: Alan Stern , Greg Kroah-Hartman , Gregory CLEMENT , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260220-ehci-orion-drop-phy-handling-v1-1-01abd9f168cc@gmail.com> <875x7rsf03.fsf@bootlin.com> Content-Language: hu From: Gabor Juhos In-Reply-To: <875x7rsf03.fsf@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Miquel, 2026. 02. 20. 14:47 keltezéssel, Miquel Raynal írta: > Hi Gabor, > > On 20/02/2026 at 14:27:02 +01, Gabor Juhos wrote: > >> Since the USB core code handles the generic USB PHYs automatically, the >> optional PHY handling code has been removed from the 'ehci-orion' driver >> entirely by commit e04585184dcf ("usb: ehci-orion: avoid double PHY >> initialization"). However, the devm_phy_optional_get() call has been kept >> so the driver still gets the PHY even though it is not used for anything >> in the driver. >> >> Drop the remaining code, and also remove the 'phy' member of the >> 'orion_ehci_hcd' structure to simplify the code. >> >> Fixes: e04585184dcf ("usb: ehci-orion: avoid double PHY initialization") > > The fixes tag makes no sense here, this is pure cleanup. I do not > remember if this was needed or not, it is probably safe to drop today. I have checked the code in v5.1, and the phy is not used there either. Nevertheless, you are right, this is a cleanup rather than a fix. I will send a v2 without the Fixes tag. Thanks, Gabor