From: Andrew Lunn <andrew@lunn.ch>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 2/2] net: phy: mtk-ge-soc: Fix LED behavior if blinking is not set.
Date: Fri, 23 May 2025 18:07:49 +0200 [thread overview]
Message-ID: <39d5d8af-0bac-4b91-85df-4e04a5835f53@lunn.ch> (raw)
In-Reply-To: <20250523113601.3627781-3-SkyLake.Huang@mediatek.com>
On Fri, May 23, 2025 at 07:36:01PM +0800, Sky Huang wrote:
> From: Sky Huang <skylake.huang@mediatek.com>
>
> If delay_on==0 and delay_off==0 are passed to
> mt798x_2p5ge_phy_led_blink_set() and mtk_phy_led_num_dly_cfg(),
> blinking is actually not set. So don't clean "LED on" status under
> this circumstance.
Actually, i think mtk_phy_led_num_dly_cfg() is wrong.
https://docs.kernel.org/leds/leds-class.html#hardware-accelerated-blink-of-leds
The blink_set() function should choose a user friendly blinking
value if it is called with *delay_on==0 && *delay_off==0
parameters. In this case the driver should give back the chosen
value through delay_on and delay_off parameters to the leds
subsystem.
That is not what mtk_phy_led_num_dly_cfg() does.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2025-05-23 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 11:35 [PATCH net-next 0/2] Add LED support/fix to MediaTek 2.5Gphy & Gphy Sky Huang
2025-05-23 11:36 ` [PATCH net-next 1/2] net: phy: mtk-2p5ge: Add LED support for MT7988 Sky Huang
2025-05-23 16:02 ` Andrew Lunn
2025-05-23 11:36 ` [PATCH net-next 2/2] net: phy: mtk-ge-soc: Fix LED behavior if blinking is not set Sky Huang
2025-05-23 16:07 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d5d8af-0bac-4b91-85df-4e04a5835f53@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®