Re: [net-next,PATCH] enetc: Set eMDIO MDC rate to 2.5 MHz only on i.MX95

[Marek Vasut <marex@nabladev.com>]

On 10/8/26 5:24 AM, Wei Fang wrote:
>>   static const struct pci_device_id enetc_pci_mdio_id_table[] = {
>> -	{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, ENETC_MDIO_DEV_ID) },
>> -	{ PCI_DEVICE(NETC_EMDIO_VEN_ID, NETC_EMDIO_DEV_ID) },
>> +	{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, ENETC_MDIO_DEV_ID), 0, 0,
>> 258 },
>> +	{ PCI_DEVICE(NETC_EMDIO_VEN_ID, NETC_EMDIO_DEV_ID), 0, 0, 66 },
>>   	{ 0, } /* End of table. */
>>   };
> 
> No, please do not add the divisor to the driver_data. All NETC v4 devices
> use the same vendor ID and device ID, but their system clock may be
> different. So the divisor is different as well.
> 
> In addition to EMDIO, the ENETC port and NETC switch port also support
> virtual MDIO, which uses their own MDIO registers to access the external
> PHY. Therefore, the modifications go far beyond this.
> 
> If you don't mind, I can add a patch set to address this issue later. You can
> simply revert the commit 587acb86d646 "enetc: Increase eMDIO MDC rate
> to 2.5 MHz".
I am tempted to do that at this point, but the MX95 would then be 
incompatible with TJA1120 which does not work for me.

But isn't the PCI_DEVICE(NETC_EMDIO_VEN_ID, NETC_EMDIO_DEV_ID) 
compatible ONLY with the MX95, so this would restore the behavior on 
non-MX95 and fix up MX95 only ?