From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 004BD1C84DC for ; Wed, 17 Dec 2025 13:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765977342; cv=none; b=kcysR379iPKbkqjrDUgAIU2I4JOH7etNvVz7LEkeDmusU9lf297lQwS1BHUT6+P0mYT/3SFihuzzeu/hHu702mo2i9qWJ0HQZrnmX/oCYzZzSAQkXujPBQNWkB5qmfudhyDZd/Vyul1eQTgZu38MHA8xTdtzWXv1+vORZljb9iI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765977342; c=relaxed/simple; bh=f96S71trim0g+HPpzGDMkG7axZcuaPQwx800ipbJaSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XFj6JE1xnckwdOJgiS6uuMbZhGvkgZXGcP3YZfXFLkfLRhz5F55lG/vG/jXtrHCrIH2vlcbK59odB+MhfWHtK+y8y2x8CoX68X/EV7zNere3DTIhk3z4lD6zUu/HcZAL10dvZeJun/4NEAOLm2h1JU8J/Km8G2NbbhY2WM8OC0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jPq914Dk; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jPq914Dk" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b73161849e1so1350560066b.2 for ; Wed, 17 Dec 2025 05:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765977339; x=1766582139; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1F+XhGDyzhWPwRMa7bHo6bLqb91juDMIm0R67eyz4L0=; b=jPq914DkYP6Sycf42AySdvrVjrqxGBhy+WT6FQ6x+tLPRE3+C5tWjfw9ixFG0ExCoo blnI0xMc/mbfL86GwJ/xQg6auTy31FzGJO6QR6AbBm4dycH3c8zUv9W8ZV4q6Lmuftfr TxPdUwe/uDSd8c0DflMAY5ceKtCfJPoGcNnKE84Z4+X1T/BAF4g0bOg5xxJT120129cu EcyAqaW60EUt8ph6jpvySuqRriCrwwm+tCP7iCa9k/6g1FCppHesxzdvvgOq2DoMsmkm kN6KVdtrao1H74IQMKEVrWSEO1V47FEJecPhh0HDQf5Tz/MoQ3I2dQmhSW/E1wX3igvI sGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765977339; x=1766582139; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1F+XhGDyzhWPwRMa7bHo6bLqb91juDMIm0R67eyz4L0=; b=wbQiQFgIEgCd36tsqUspjM2XsMN8uaDt55eAXB/Xxv+e9+rBysgHkx5EiUMVxDUDZu bsube+9mOny5GVAcxffEEYvAxrLVTk6ZfPTdC0PFa73KE0kHr+Wrd843hllS/F0zonvb AiKkqxH+5fCVctpR8bWuT9A+3/YzS+z52TQUv59P1Gco4m4q7fx666nfcqgi7vcye1/m u6BFFNMeciA5pg1TVDmXZPmjR/X+yJeYzC6mlavZey8FTMZQr7GWjphMfG5hImpuRmAF qdHzfATw/okvOKZWnN9YSouWZH3a1ysJujk4XWtHlcRcyUHWVFcXVHiB8EfyaGZSYZqB BXtg== X-Gm-Message-State: AOJu0YwGNsHRTUq6vV4OkUgUpP08LDvLUTdgZqbaUS+RYxR9k++O+bh8 WbDKDFr3rfmCc6uOKCwk+/VCo7IzXfOJ99D/T/ZxXlAu9njQd8CujQG1 X-Gm-Gg: AY/fxX6e/efEit+A2/Yw9apmFXaarLBofrzhJm2IUpiYctZCE4Eiq1j2qkaiYBqRiDv W5UGpprMkOWDxoROlUNw+BUt2cxwg+j4jT28Ll4VoG12Z3YG6xl7B7PRnwMjqVl/KANYSijuPwE 6+pyV5kzB/jHj6mhd4is97QCkPro4CAgv4jfKhPqNAomQ22c9qTX+aJWcObKaAJ94m7Lz9RKA9h AoMlKcPU3YpEmX8OfWdUvkVAmFLW+G4fvjb1a/YxWjvdV/vbopda0cXC5rqw1vDL7sZ++Nli5Je c1bJsIdu0sW5cs/ge1O1S1p3TjfpopbU2GK4cNBso/T/rUT/cHT/UuYs6YiDAvUHE/BD5jJEq9N uRiYWZ+R6plDwWhFfm97vary4qFOcHN7FZbuPjA7xm4kIcfwbqJeAi/cACqHd8ookPvqSF/q7x5 KboZKdH7/EEp0RXpysGJzubPh65438TSsN8N7d0U6xLaeVuIj4+w54xWnpBPFm/4EUulhfboX+e ABEUPKUsWDQOUn+ZNhpcPcgT+HIoXpnrQVwvMJtvwumGMsfJ67XUflz5pid/JiH2BU65fk7p1Y= X-Google-Smtp-Source: AGHT+IFJFc+tAj9+1ZWQ33lxgGX+8wQEs7FAeIC0HBzWXEDQ1X33lh9OIi5obJ3o1fl/Fh8XvLSyBw== X-Received: by 2002:a17:907:3d92:b0:b7a:2ba7:197f with SMTP id a640c23a62f3a-b7d23a63a2emr1945186566b.52.1765977338934; Wed, 17 Dec 2025 05:15:38 -0800 (PST) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa29f51esm1970726066b.14.2025.12.17.05.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 05:15:38 -0800 (PST) Message-ID: <39e285e0-81b7-47b2-b36f-50de7e51f95b@gmail.com> Date: Wed, 17 Dec 2025 13:15:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: access @pp through netmem_desc instead of page To: "Loktionov, Aleksandr" , Byungchul Park , "netdev@vger.kernel.org" , "kuba@kernel.org" Cc: "linux-kernel@vger.kernel.org" , "kernel_team@skhynix.com" , "harry.yoo@oracle.com" , "david@redhat.com" , "willy@infradead.org" , "toke@redhat.com" , "almasrymina@google.com" , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "intel-wired-lan@lists.osuosl.org" References: <20251216040723.10545-1-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/17/25 11:46, Loktionov, Aleksandr wrote: > > >> -----Original Message----- >> From: Intel-wired-lan On Behalf >> Of Byungchul Park >> Sent: Tuesday, December 16, 2025 5:07 AM >> To: netdev@vger.kernel.org; kuba@kernel.org >> Cc: linux-kernel@vger.kernel.org; kernel_team@skhynix.com; >> harry.yoo@oracle.com; david@redhat.com; willy@infradead.org; >> toke@redhat.com; asml.silence@gmail.com; almasrymina@google.com; >> Nguyen, Anthony L ; Kitszel, Przemyslaw >> ; andrew+netdev@lunn.ch; >> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; intel- >> wired-lan@lists.osuosl.org >> Subject: [Intel-wired-lan] [PATCH net-next] ice: access @pp through >> netmem_desc instead of page >> >> To eliminate the use of struct page in page pool, the page pool users >> should use netmem descriptor and APIs instead. >> >> Make ice driver access @pp through netmem_desc instead of page. >> > Please add test info: HW/ASIC + PF/VF/SR-IOV, kernel version/branch, exact repro steps, before/after results (expected vs. observed). > >> Signed-off-by: Byungchul Park >> --- >> drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c >> b/drivers/net/ethernet/intel/ice/ice_ethtool.c >> index 969d4f8f9c02..ae8a4e35cb10 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c >> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c >> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct >> ice_rx_ring *rx_ring) >> rx_buf = &rx_ring->rx_fqes[i]; >> page = __netmem_to_page(rx_buf->netmem); >> received_buf = page_address(page) + rx_buf->offset + >> - page->pp->p.offset; >> + pp_page_to_nmdesc(page)->pp->p.offset; > If rx_buf->netmem is not backed by a page pool (e.g., fallback allocation), pp will be NULL and this dereferences NULL. > I think the loopback test runs in a controlled environment, but the code must verify pp is valid before dereferencing. > Isn't it? Considering "page->pp->p.offset" poking into the pool, if that can happen it's a pre-existing problem, which should be fixed first. -- Pavel Begunkov