From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbdAYTAQ convert rfc822-to-8bit (ORCPT ); Wed, 25 Jan 2017 14:00:16 -0500 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:47667 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751658AbdAYTAO (ORCPT ); Wed, 25 Jan 2017 14:00:14 -0500 From: Jon Pannell To: Gregory CLEMENT , Andrew Lunn , Bob Bernstein CC: Vivien Didelot , Florian Fainelli , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Jason Cooper , "Sebastian Hesselbarth" , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Nadav Haklai , Wilson Ding , Kostya Porotchkin , Joe Zhou Subject: RE: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Thread-Topic: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Thread-Index: AQHSduBsenegsTrRC0WFtYFcFIfenaFJjAXA Date: Wed, 25 Jan 2017 18:58:25 +0000 Message-ID: <39e62380a498403d94961d066a8bba6b@SC-EXCH01.marvell.com> References: <20170125020249.GB24034@lunn.ch> <8760l3375t.fsf@free-electrons.com> In-Reply-To: <8760l3375t.fsf@free-electrons.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-25_14:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701250177 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding Bob Bernstein Jon Pannell -----Original Message----- From: Gregory CLEMENT [mailto:gregory.clement@free-electrons.com] Sent: Tuesday, January 24, 2017 11:56 PM To: Andrew Lunn Cc: Vivien Didelot ; Florian Fainelli ; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller ; Jason Cooper ; Sebastian Hesselbarth ; Thomas Petazzoni ; linux-arm-kernel@lists.infradead.org; Nadav Haklai ; Wilson Ding ; Kostya Porotchkin ; Joe Zhou ; Jon Pannell Subject: Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Hi Andrew, On mer., janv. 25 2017, Andrew Lunn wrote: >> + [MV88E6341] = { >> + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, >> + .family = MV88E6XXX_FAMILY_6341, >> + .name = "Marvell 88E6341", >> + .num_databases = 4096, >> + .num_ports = 6, >> + .port_base_addr = 0x10, >> + .global1_addr = 0x1b, >> + .age_time_coeff = 15000, > > Hi Gregory > > Please could you check this timer in the datasheet. There is currently > a bug in the mv88e6390 support code. I also set it to 15s. But in fact > it is 3.75 seconds. The 6341 might also use 3.75 seconds. When I read your series I also thought about it and indeed it is 3.75 seconds. I will fix it. Thanks, Gregory > > Thanks > Andrew -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com