mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Yan Zheng <yanzheng@21cn.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Stevens <dlstevens@us.ibm.com>
Subject: Re: [PATCH][MCAST]IPv6: small fix for ip6_mc_msfilter(...)
Date: Wed, 2 Nov 2005 19:55:50 -0200	[thread overview]
Message-ID: <39e6f6c70511021355i52aff7e4n19ca4c1e24b21bb7@mail.gmail.com> (raw)
In-Reply-To: <4367FF22.3030601@21cn.com>

On 11/1/05, Yan Zheng <yanzheng@21cn.com> wrote:
> David Stevens wrote:
> > Yan,
> >         Please also make this equivalent change in IPv4 with
> > ip_mc_msfilter() and ip_mc_add_src().
> >
> >                                                 +-DLS
> >
> > Acked-by: David L Stevens <dlstevens@us.ibm.com>
>
> To keep code style, I also create a new patch for IPv6. :-)
>
> Signed-off-by: Yan Zheng <yanzheng@21cn.com>
>
> Patch for IPv4
> Index:net/ipv4/igmp.c
> ============================================================
> --- linux-2.6.14/net/ipv4/igmp.c        2005-10-28 08:02:08.000000000 +0800
> +++ linux/net/ipv4/igmp.c       2005-11-02 07:31:01.000000000 +0800
> @@ -1908,8 +1908,11 @@ int ip_mc_msfilter(struct sock *sk, stru
>                         sock_kfree_s(sk, newpsl, IP_SFLSIZE(newpsl->sl_max));
>                         goto done;
>                 }
> -       } else
> +       } else {
>                 newpsl = NULL;
> +               (void) ip_mc_add_src(in_dev, &msf->imsf_multiaddr,
> +                       msf->imsf_fmode, 0, NULL, 0)

Could you please compile test it next time :-) hint, missing ';'.
Anyway, fixed up by hand.

- Arnaldo

  parent reply	other threads:[~2005-11-02 21:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31  2:52 Yan Zheng
2005-11-01 10:37 ` Yan Zheng
2005-11-02  5:47   ` Willy Tarreau
2005-11-02  7:10     ` David Stevens
2005-11-02  9:29       ` Willy Tarreau
2005-11-02 13:41         ` Marcelo Tosatti
2005-11-02 21:31           ` [PATCH-2.4][MCAST]IPv6: " Willy Tarreau
2005-11-02 17:42         ` [PATCH][MCAST]IPv6: " David Stevens
2005-11-02 20:59           ` Marcelo Tosatti
2005-11-03  5:02             ` Willy Tarreau
2005-11-02 21:46           ` Arnaldo Carvalho de Melo
2005-11-01 21:27 ` David Stevens
2005-11-01 23:49   ` Yan Zheng
2005-11-01 23:55     ` David Stevens
2005-11-02 21:45       ` Arnaldo Carvalho de Melo
2005-11-02 21:55     ` Arnaldo Carvalho de Melo [this message]
2005-11-02 23:28       ` Yan Zheng
2005-11-02 23:28         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39e6f6c70511021355i52aff7e4n19ca4c1e24b21bb7@mail.gmail.com \
    --to=acme@ghostprotocols.net \
    --cc=dlstevens@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yanzheng@21cn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®