From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: spereira@tusc.com.au, linux-kenel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Andi Kleen <ak@muc.de>,
SP <pereira.shaun@gmail.com>
Subject: Re: [PATCH] net: 32 bit (socket layer) ioctl emulation for 64 bit kernels
Date: Mon, 9 Jan 2006 09:31:08 -0200 [thread overview]
Message-ID: <39e6f6c70601090331g3eaa4b0ge3b8102e94a7af65@mail.gmail.com> (raw)
In-Reply-To: <200601091054.35010.arnd@arndb.de>
On 1/9/06, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 09 January 2006 06:46, Shaun Pereira wrote:
> > Since we are interested in ioctl's from userspace I have not added the
> > .compat_ioctl function pointer to struct net_device. The assumption
> > being once the userspace data has reached the kernel via the socket api,
> > if the socket layer protocol knows how to handle the data, it will
> > prepare it for the device.
>
> I think we need to have it in the long run, but if you don't need it
> for x25, then it's not your call to implement net_device->compat_ioctl.
> I've been thinking about how to get it right before, but did not
> reach a proper conclusion, since dev_ioctl is called in so many places
> that would all need to be changed for this.
Nowadays dev_ioctl is only called from one funcion: sock_ioctl in
net/socket.c, this is after a recent changeset by hch.
- Arnaldo
next prev parent reply other threads:[~2006-01-09 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 6:46 Shaun Pereira
2006-01-09 10:54 ` Arnd Bergmann
2006-01-09 11:31 ` Arnaldo Carvalho de Melo [this message]
2006-01-11 6:28 ` Shaun Pereira
2006-01-11 12:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e6f6c70601090331g3eaa4b0ge3b8102e94a7af65@mail.gmail.com \
--to=acme@ghostprotocols.net \
--cc=ak@muc.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pereira.shaun@gmail.com \
--cc=spereira@tusc.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®