From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932692AbdGXRbj (ORCPT ); Mon, 24 Jul 2017 13:31:39 -0400 Received: from foss.arm.com ([217.140.101.70]:35740 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932546AbdGXRap (ORCPT ); Mon, 24 Jul 2017 13:30:45 -0400 Cc: Sudeep Holla , Linux Kernel Mailing List , Rob Herring , Alexey Klimov , Loc Ho , Mark Rutland , "arnd@arndb.de" , Jassi Brar , Roy Franz , Harb Abdulhamid , Matt Sealey , ALKML , DTML , Nishanth Menon Subject: Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI To: Jassi Brar References: <1498492513-29771-4-git-send-email-sudeep.holla@arm.com> <1499446341-5956-1-git-send-email-jaswinder.singh@linaro.org> <5f2e4f3c-297b-c5f8-9244-399c1c4e2c21@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <39eeddc1-99fb-092a-a833-cf4024695d87@arm.com> Date: Mon, 24 Jul 2017 18:30:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/07/17 18:21, Jassi Brar wrote: > On Mon, Jul 24, 2017 at 9:51 PM, Sudeep Holla wrote: >> On 24/07/17 16:41, Jassi Brar wrote: > >>> SCMI calls >>> mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer); >>> >>> whereas the API expects >>> mbox_send_message(struct mbox_chan *chan, struct controller_specific *xfer); >>> >> >> That's not hard to change ... > > Cool, please change it and lets move on. > But tell me why first ? You said it needs to work with any controller. And now you say I need to change it to some controller_specific ptr, won't that make it controller specific protocol ? You responded on something you wanted ignoring all the other parts, still waiting for those response. 1. Tell me how my changes to MHU and SCMI are related ? 2. How my MHU changes and PCC are different ? Why do you think this SCMI is FUBAR design which the clients using PCC are not ? -- Regards, Sudeep