From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbdHEMad (ORCPT ); Sat, 5 Aug 2017 08:30:33 -0400 Received: from mout.web.de ([212.227.17.11]:56146 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdHEMab (ORCPT ); Sat, 5 Aug 2017 08:30:31 -0400 Subject: [PATCH 3/4] atm: idt77252: Improve seven size determinations From: SF Markus Elfring To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <39f09a7c-b6a6-9694-133f-237fba64a2dd@users.sourceforge.net> Date: Sat, 5 Aug 2017 14:30:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eRveE6doxIFtFauwvjAGu7P5mPNTaKkvlpK1f8hhNeCAiYDFa1Z yL8m9DtWqt2gKEqQUUCszzEXQ1qI/8hw9S7o0LftuJILWDGTc0qHwpUJzD2CnwXASYCmGy9 qsCjTPI7RzIw45olYxNdexXU0PykM202BrR4FmUgV9gk0VWsRu+UjaJJRPMU+6jcvDbqk0o pqS2mivpq+/QWUa1iQDUw== X-UI-Out-Filterresults: notjunk:1;V01:K0:HJJOwB/+rBo=:8LBaqm2BNGjn07eMf2fuRl bnBNacZYjtmD0mBWA3CYX0xOL2dfqqQis3GhjkvKBB6NW83zNDwynWJTP05lg3rYCheyKhitz 1NzD/RgLJz6Y7xiPRyCDf4l96XEf/qZJutf2F21ZJAMVuCE4KRENWOeKJpS4LV5m1oTIpX84P BmJ16pYlc9JBp2vXIqOXUoyDUEj1EB8VfDyW12qOoF0AQfAxGzGlQJHnFidUDVQKzrYT7Ki8G /pmVxjnUK2wS8FWGfHD/ywxcC4ZKR2Ki0fjx4yI3vm2uA+5xBxwZ8wOZJB3LGlStEit/6e6W6 mZjWI+ggL0Wv8iWhFsyPsAHYlrjVtCvxplUbFA593n65wpX/QhWnN6V4nraaVt2qHOygTa9jV pmyTly19jdBM+3X62GWGquYesEPXb2KKeRKnvT8iAd+o75KYBAWnurn1V4mN0vUBml3N8Qhzi EnM8h691Nhs8uKEDpK/EecGK2s/k4g38T0v+NPOiPWeSYb/2ppcOOwvkdfEDyAAVDj9eiwoCl Uo0ZyV3PZnL0AlaXVC/fW+1nsv7uSBgHYJAhrmT4rLmyewbr+dlE4sBKbalqvOqnpJwGzZiZ5 u2smun8J7ioM+KEa2dPj8rw7B2Vnr3IDw0WFWaNOnWwdYAzeojFW1JudkwRa6sSRcexFOr4u5 2KXiZyzeWvIgAvuKEiypJ6pj8+MCeSracvj7wixwJP0owqSAPHvqGBX76wFsK7jEF25JwsWVc 0S0YQ2lU4pRA36mDYhMTTLQRow6+XFq7eGCplzMfFGZMBztwEZ9PGMZ8Jw4NGtZclIEtb1lkf rIT3oH6CkxbL8os2wDq/w75QyU0eFz7JiK8J/cTHDa4kRrqegQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 5 Aug 2017 13:51:04 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/idt77252.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 434dc4ee5f15..e26e36a934e9 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -638,7 +638,7 @@ alloc_scq(struct idt77252_dev *card, int class) { struct scq_info *scq; - scq = kzalloc(sizeof(struct scq_info), GFP_KERNEL); + scq = kzalloc(sizeof(*scq), GFP_KERNEL); if (!scq) return NULL; scq->base = dma_zalloc_coherent(&card->pcidev->dev, SCQ_SIZE, @@ -2119,7 +2119,7 @@ idt77252_init_est(struct vc_map *vc, int pcr) { struct rate_estimator *est; - est = kzalloc(sizeof(struct rate_estimator), GFP_KERNEL); + est = kzalloc(sizeof(*est), GFP_KERNEL); if (!est) return NULL; est->maxcps = pcr < 0 ? -pcr : pcr; @@ -2422,7 +2422,8 @@ idt77252_open(struct atm_vcc *vcc) index = VPCI2VC(card, vpi, vci); if (!card->vcs[index]) { - card->vcs[index] = kzalloc(sizeof(struct vc_map), GFP_KERNEL); + card->vcs[index] = kzalloc(sizeof(*card->vcs[index]), + GFP_KERNEL); if (!card->vcs[index]) { mutex_unlock(&card->mutex); return -ENOMEM; @@ -2612,8 +2613,7 @@ idt77252_change_qos(struct atm_vcc *vcc, struct atm_qos *qos, int flags) goto out; } - memcpy(&vcc->qos, qos, sizeof(struct atm_qos)); - + memcpy(&vcc->qos, qos, sizeof(*qos)); set_bit(ATM_VF_HASQOS, &vcc->flags); out: @@ -2851,8 +2851,7 @@ open_card_oam(struct idt77252_dev *card) for (vpi = 0; vpi < (1 << card->vpibits); vpi++) { for (vci = 3; vci < 5; vci++) { index = VPCI2VC(card, vpi, vci); - - vc = kzalloc(sizeof(struct vc_map), GFP_KERNEL); + vc = kzalloc(sizeof(*vc), GFP_KERNEL); if (!vc) return -ENOMEM; @@ -2918,7 +2917,7 @@ open_card_ubr0(struct idt77252_dev *card) { struct vc_map *vc; - vc = kzalloc(sizeof(struct vc_map), GFP_KERNEL); + vc = kzalloc(sizeof(*vc), GFP_KERNEL); if (!vc) return -ENOMEM; @@ -3605,7 +3604,7 @@ static int idt77252_init_one(struct pci_dev *pcidev, return err; } - card = kzalloc(sizeof(struct idt77252_dev), GFP_KERNEL); + card = kzalloc(sizeof(*card), GFP_KERNEL); if (!card) { err = -ENOMEM; goto err_out_disable_pdev; -- 2.13.4