From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE8881D5CDE for ; Fri, 19 Dec 2025 15:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766158871; cv=none; b=BMVGO0T3cH7LJyrPLkVPWZwoaqmfi1s8uXuUy2OfmA+HJ16uA/15sLNKXl3a2ffx4D47nxRAw3ZGi6TfTBPEshsWpDvqU3A9yo5EbTXG09Dz7GJSxE2IHW3Wrs4ouVyrRd0J4rHPGG0m/NcbiKXQAi7R3+CFd5ZGdb8IkX0vZ2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766158871; c=relaxed/simple; bh=BRrNcZvVlDwSwnRRU6a5m2aesMieJkkg9nkD+8nzge0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T76QlQnvRW9afUVrnimh4c/anJxSbSER66+n92i7tFDvJykt1kPv54261+SMsjchV19RkaynIRLhZ2jmVS66fVZwZfzqtF9LEmk0T3fkn0190QtgoDgFsOC0QiVCaSgj7pJsRbmyYwThIy04Tdx4hea3PQA94uvh1yv2solOveY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iFtIVfnA; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iFtIVfnA" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a07fac8aa1so20217385ad.1 for ; Fri, 19 Dec 2025 07:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766158869; x=1766763669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=IPXvnEl86h7uXlbydiQlqn600f4rTYS35PhjEa5747s=; b=iFtIVfnAtO1qW3qBvxdns8ezPF6L0ayGcwsTRztB9fbtbo/DHO62xPPZJmEQ1Pq3wF u4K4O1GUXd3omsBvlYr1LlR2zHJipXeFjOCf66GyCz2k3A6vIwYuMUwDns68U17PqGxk qKSZ64+k0gBKpowVEPZStDu+ZFi3HEIjOhQZDEOeJl1itpa+wF3JRxNc4nAgTDTS0yOW 6lpKze08D0aGOzMu7U5dbjv14dx7Aw1HZ3CfAR2Nn7A0UZxzkIGOOfzi/sY+N8+VuCyC W831NVhOQRdVdLp06Larh+lyZe5q2TEZxeV3UUuDw3rrKSaB19u6RncdRtFTQM3CdWR2 E9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766158869; x=1766763669; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IPXvnEl86h7uXlbydiQlqn600f4rTYS35PhjEa5747s=; b=JZNCfMJ2hYEpRyut9jX76fTuOdt85Q7QyoQKimrmx9HqeuqfW+1toXmg+3ijDi3Fby ET3feDhpnu9hs4LYNdV6B38869jXbXAOwyzDr3tOUUxIyVmqyOFL0ZpWmgXyAS+byfNP sbzk20NGc7e7HLeXywNwxwcL3QgxgjK8il49KoOHodLw7fSrTzw/TmWSok1Mxwj5YhWN P1WCtvOHjPhzXqHikNSLJxJ3VYXY7UlVwUzNpMLVCEAFAqtde44F/tAYWqqiw05aLrlN fpJm2NLxv7S1+mEUixDrPtXVzJYGt6myvuHc4UxMoAxMitMvfhDdxUvy07Ri1u9E+xnh wYZQ== X-Forwarded-Encrypted: i=1; AJvYcCVIDHwsjHv+TbtyiCrBa+cfncHKJtuRsDB3ymSqzwHdlORfmCdHjkPsR8YwiEWA7bOk/OolFyLFYIGlL1s=@vger.kernel.org X-Gm-Message-State: AOJu0YySgtv8ofCFEQVx67igrtz5bXGvOwRnSm2j2S/hbqMMo6xvHmqI jBE6g1MWZXdAbgJ4RAj7osoR7Rdxg4a4XREDBas5Q0SfVpPd2OOp6Djr X-Gm-Gg: AY/fxX74wXOMrsk9oYc+zMNRMyxCIiVE27PJJzawKvuESQVbTZdv2JraQAPao+TTD7K 3j8hA9u/Bs4l3OJo2mNMOfabQ+JxE1gEc8WiXAuWfkWynS04PglL1hInuipXgYsfDl/ExsPxu6Y Zf1EkHiNMKB41WAt4lDCod4EcL7YQPU7J4tOyG2T8ZofNIDH2b1NaQsV+bI8QmYlm8+7B4K3ls1 15PKZhDowSzagLrP57zZEZKqvvYDr/qIXgbHX9KDAU+JS6HbFfBmtkJ4b84RqyfQINHPr9iIO6e 4VfVRUcAmNmq7MWuPlGViZx1Skz18GdBQ89rHsjlS4Bn58NCE6JtRWT7X9eNLhglWSh466biUuw wmETtYFuYVQGkgG/xqhctLgtYkl89r3Iaam1HmSVBj+6ISYA2W84ycD/Kcj+m+d6QaEVckEJXoE PqGNvscNW5T9HXF1MWRSGYNZ8b3Ph7uVeOLEqV8hX10P2BjvS1VW4lQ7Xi5B9l X-Google-Smtp-Source: AGHT+IHqFQr9VCsCz94jfHlAbFf1IeLSnEtxm0lVZUjn+gonTVrzhD4100xdi7kegdd/YqdS1Bi3rw== X-Received: by 2002:a17:902:e748:b0:295:738f:73fe with SMTP id d9443c01a7336-2a2f2732287mr32089865ad.30.1766158869094; Fri, 19 Dec 2025 07:41:09 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d5dea1sm25677395ad.81.2025.12.19.07.41.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 07:41:08 -0800 (PST) Sender: Guenter Roeck Message-ID: <39f2a3ac-6906-4970-822e-d1f5cdced563@roeck-us.net> Date: Fri, 19 Dec 2025 07:41:07 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkje+8miBbUEFUQ0hdIHdhdGNoZG9nOiBzYnNhLWd3ZHQ6?= =?UTF-8?Q?_clamp_timeout_before_updating_wdd-=3Etimeout?= To: 1536943441 <1536943441@qq.com>, linux-watchdog Cc: wim , linux-kernel References: <6fda7aa7-244a-4650-b120-acd66ca0d1c9@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/19/25 01:46, 1536943441 wrote: > Hi Guenter, > > thank you for the detailed explanation. > > I misunderstood the watchdog core semantics here. With max_hw_heartbeat_ms set, the userspace timeout can represent a virtual timeout and is not expected to be limited by the single hardware timeout. Given that, my change is indeed wrong > and I will drop this patch. > > One follow-up question: in my testing, "/sys/class/watchdog/watchdog0/max_timeout" always shows 0 for sbsa-gwdt.  Should the driver set wdd->max_timeout in probe(), or is a 0 value expected when max_hw_heartbeat_ms/virtual timeouts are used? > The value is as expected, and the driver should not do anything. A value of 0 means "unlimited", which in practice means that the limit is UINT_MAX / 1000. Turns out the attribute is not documented. We should add it to the ABI documentation. If/when I find the time ... Thanks, Guenter