From: David Heidelberg <david@ixit.cz>
To: "Nagashima, Shunsuke" <shunsuke@nagashi.ma>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Jeff Johnson <jjohnson@kernel.org>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
linux-kernel@vger.kernel.org,
Fabricio Akio <fabricioakio@gmail.com>,
Aleksei Kharlamov <aleksei.kharlamov@gmx.de>,
Conn O'Griofa <connogriofa@gmail.com>,
phone-devel <phone-devel@vger.kernel.org>
Subject: Re: [PATCH ath-next 1/3] wifi: ath10k: set the PMF peer flag on WCN3990
Date: Wed, 4 Nov 2026 12:16:11 +0100 [thread overview]
Message-ID: <39f54b47-e21d-41e9-b7a3-12f121517f8d@ixit.cz> (raw)
In-Reply-To: <CACB3TCKq--tdL6j+uGR_dxGdy-gHxQhY8p0h6xxqi_4Fd3VEOQ@mail.gmail.com>
On 02/11/2026 23:51, Nagashima, Shunsuke wrote:
> Hi Loic,
>
> On Mon, Nov 2, 2026 at 12:56 PM Loic Poulain wrote:
>> So why not updating firmware-5.bin file instead?
>>
>> There is a tool available here:
>> https://github.com/qca/qca-swiss-army-knife.git
>
> Thank you for the suggestion and for the pointer to ath10k-fwencoder.
>
> I had tried that first. On my comma four, a local firmware-5.bin with
> the mfp-support bit set gave the same result as this patch: the
> protected Deauth carried a live PN, and the next association was not
> rejected. It is also the file I used for the overnight PMF runs in the
> notes of patch 3.
>
> I went for a driver change instead for two reasons:
>
> - I was not sure whether it was fine to change a firmware file that
> Qualcomm provides.
> - Other devices seemed to have the same problem. No WCN3990
> firmware-5.bin in linux-firmware sets the bit, including the newest
> one (shikra), and Aleksei (WCN3988) and Conn (QCA9377) reported the
> same issue in this thread.
>
> So I'll drop this patch and send a firmware-5.bin update to
> linux-firmware instead. Patches 2 and 3 do not depend on this one.
> Should the update change the shared WCN3990/hw1.0/firmware-5.bin, or
> add a file for one board?
ath10k-fwencoder --modify --features=wowlan,mgmt-tx-by-ref,non-bmi,mfp-support
firmware-5.bin
for the OnePlus 6 (oneplus,enchilada) issue "speed not exceeding 10Mbit issue"
on the WPA3 enabled router for too.
David
>
> Aleksei, Conn: a firmware file update only helps devices that load that
> file. If you have time, could you make the same change to the
> firmware-N.bin your device loads, test it, and send it to
> linux-firmware?
>
> I worked through this with Claude (AI). English is hard for me, so AI
> helped write the English. I ran all the device tests myself on my comma
> four.
>
> Thanks,
> Shunsuke Nagashima <shunsuke@nagashi.ma>
next prev parent reply other threads:[~2026-11-04 11:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 0:17 [PATCH ath-next 0/3] wifi: ath10k: WCN3990 station fixes for PMF and failed connections Shunsuke Nagashima via B4 Relay
2026-10-16 0:17 ` [PATCH ath-next 1/3] wifi: ath10k: set the PMF peer flag on WCN3990 Shunsuke Nagashima via B4 Relay
2026-10-19 23:04 ` Aleksei Kharlamov
2026-10-20 2:47 ` Nagashima, Shunsuke
2026-10-20 14:12 ` Aleksei Kharlamov
2026-10-30 18:17 ` Conn O'Griofa
2026-11-02 11:56 ` Loic Poulain
2026-11-02 22:51 ` Nagashima, Shunsuke
2026-11-02 23:57 ` Conn O'Griofa
2026-11-03 9:20 ` Loic Poulain
2026-11-03 11:07 ` Nagashima, Shunsuke
2026-11-03 13:46 ` Loic Poulain
2026-11-03 16:44 ` Nagashima, Shunsuke
2026-11-04 11:16 ` David Heidelberg [this message]
2026-10-16 0:17 ` [PATCH ath-next 2/3] wifi: ath10k: skip disassociation down for a station vdev that is not up Shunsuke Nagashima via B4 Relay
2026-10-16 0:17 ` [PATCH ath-next 3/3] wifi: ath10k: bring down a station vdev that never came up Shunsuke Nagashima via B4 Relay
2026-10-19 13:12 ` James Prestwood
2026-10-19 22:56 ` Nagashima, Shunsuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39f54b47-e21d-41e9-b7a3-12f121517f8d@ixit.cz \
--to=david@ixit.cz \
--cc=aleksei.kharlamov@gmx.de \
--cc=ath10k@lists.infradead.org \
--cc=connogriofa@gmail.com \
--cc=fabricioakio@gmail.com \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=phone-devel@vger.kernel.org \
--cc=shunsuke@nagashi.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®