Re: [PATCH net-next] net: phy: realtek: Add support for WOL magic packet on RTL8211F

[Andrew Lunn <andrew@lunn.ch>]

> +static void rtl8211f_get_wol(struct phy_device *dev, struct ethtool_wolinfo *wol)
> +{
> +	struct rtl821x_priv *priv = dev->priv;
> +
> +	wol->supported = WAKE_MAGIC;
> +	wol->wolopts = priv->saved_wolopts;

Can the current configuration be read from the hardware, rather than
using a cached value. The BIOS could for example enable magic packet,
and Linux inherits it.

> +static int rtl8211f_set_wol(struct phy_device *dev, struct ethtool_wolinfo *wol)
> +{
> +	struct rtl821x_priv *priv = dev->priv;
> +	const u8 *mac_addr = dev->attached_dev->dev_addr;
> +	int oldpage;
> +
> +	oldpage = phy_save_page(dev);
> +	if (oldpage < 0)
> +		goto err;
> +
> +	if (wol->wolopts & WAKE_MAGIC) {
> +		/* Store the device address for the magic packet */
> +		rtl821x_write_page(dev, 0xd8c);

Does the datasheet have names for these magic values? Please add
#defines.

	Andrew