From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbdBGEut (ORCPT ); Mon, 6 Feb 2017 23:50:49 -0500 Received: from mail-bl2nam02on0078.outbound.protection.outlook.com ([104.47.38.78]:22336 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751789AbdBGEur (ORCPT ); Mon, 6 Feb 2017 23:50:47 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v8 3/9] perf/amd/iommu: Misc fix up perf_iommu_read To: Peter Zijlstra References: <1484551416-5440-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1484551416-5440-4-git-send-email-Suravee.Suthikulpanit@amd.com> <20170123123330.GY6485@twins.programming.kicks-ass.net> CC: , , , , From: Suravee Suthikulpanit Message-ID: <39fa57a2-7667-a8e4-6ae1-fc90f3b11d82@amd.com> Date: Tue, 7 Feb 2017 11:50:27 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170123123330.GY6485@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [171.96.222.170] X-ClientProxiedBy: SG2PR0302CA0011.apcprd03.prod.outlook.com (10.170.129.21) To BN6PR12MB1441.namprd12.prod.outlook.com (10.172.24.18) X-MS-Office365-Filtering-Correlation-Id: 7db17947-df5d-475a-9ecc-08d44f14e043 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:BN6PR12MB1441; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1441;3:9Vd2kPfiYZehFdjKwsFlFABqqyNTc40PLBJeTqV4HKrafM6wik9psxowb0F2G+jJpepPLGpI1nLAgL/NEWnIhPRXXzxX+jm6GEG+kbX4sQmm43drNMJ7SHfSnVWfMhTmWvTmvYGVduQLzRXKxDNkpRBC4Yq8Q9MzzxM3CLNCqgPCXgN2XTJIEUw3rXAhewsVqqCou+B0U+Q0pmMceTGpFcqyOYC/sHaHYU6JpZl3++Ww9bEp+966pLwBoxwBfe2H3TzwtfPbmx++jNAM6xIVFH6skcoZNBybWjuAQ7iWLBg=;25:c7lLZY5DGeqH9J2kFInonVR8BRujHOpL6VyFlLhuTc0Lk5QamUNVSDT8u/aGaBgf/7zap27nqMJr80J6FCVQuKy8tm5K4Xrosa7eZr/BJpWen9Me1hnUtdHOj1/26r0uiDvzWecHN8+JpW2j0Dsn0V5fpl5I/hwcbblk7FQ0gW/PkPO5j3ub1Nxmpq15MGdgu/a/mNcbiFvXOKmV9o/BNgUoSEf1HqCjTq9QJMSlfitWGj0glCJ9QwhUPv3twfu1vN55hxsqtyQU/2px0/J+natfWjc4eSU9zusEOLgKS5y8FVZL8LIsQ8p0euXJvRIb6lLsMtwlQzVFmLtxzNOcEeLVhRy3YiM9nP3Iu1nHpnZzruypjLtsD1ZwOKY/7klIafdUlT86wuGZk5E3/mX+2qlDoNhWrYKSFk2NVTUY/1sg/XYqpFIg4DUPGFYnO0WdwZff9j+lpHfexpYfrwn+1g== X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1441;31:v3LKMEH/gei/aj28ENxGw/hT/tDsryKQj/qnQY/9ZmU7f3dgS1y4c3I3WAMSoqoR58yhswwWNTU8nZuESZpuuvtId5YPP0HU4U39WS3nn1isCtdsKXeseHlLw52yDobUBCHx77fGA5IMmC7rFaAXurBZQkblHajOv6OGfdo1tSjlPo/+R5c/9fB7vHiz0Ut++3v1ZN6hcetW3TzCW4fGihbxqn3I30QzB4n2QxBRepmS900kxodA2zSWWqPPQwSNhs/qf5JXOObViGgkebZr72YXYCSCsK+u+w17/WM8ts4=;20:0XtLnMSvn4sEAp3/ME/g71AINe6fip+TWqhJtRyGfbYkIiZsTLUveQt4dHJgBkRGTOm2lx8ngFiFqysNAQyVkyk++0GhoxxXqpCS4KI3fVZDbxSQUE4HuJMj+EGwYnse3nyewkTKCEtpShhgw8VTE9htAORA5IcLxiOYTHOC6s7AcORkrcRYzqZgNJHz0/MQ6KuSKpG/gZrz0u42tjr0ZaXn6sCJtk9q7YT64DRdM9w8qngnnjn1J8P61IgUhphaiWvOowNiXfEH35TBeROJZ6DAjcqIv+7GctV8k1oGWh9/gLk4DhdYVZiPxwoiJ0D2MyG1mGEaL1OnrxiDW+EvIAHe3yJd6bLy3tejXSjFOIAA4YluuEPLibqLSB8VBnnQ94hv5gNx5BY2X1+itjuswDXJ15Hx+wUnSgW5HT2jkVI9RCWyO409oJi+HUNh5GdbFlJJZDPXrUp4jvlilGuvH+ji5Q3oSq0UZ4zEX5dDXGM/5AcHN/vXSCTk1/pEeCJ9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(2017020601046)(8121501046)(20170203043)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(20161123558025)(6072148);SRVR:BN6PR12MB1441;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1441; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1441;4:AoyWZh3FtTl4kfBNtEBraJg1Rwl9oQKjCOYVDw94FbI5AzTU7Rn1TF1RG/IM/icMQ84yiDQHxbBXtUK67pfIFVvmTkaPh/y1iJg7lkypbhSywex8qLkAPw1GyEE3wZBtx8P1W4biQB2dvEGsC3rGuF8OXLMh7aWw+5aTcDCEKzWhVNLVxfr0AjxWqZn9A0q9GWXBXyt/rRMmoMQrkOr55Pvs/r7EOIq+fyMNL+q7uk1QqyJhqzyAO6ImgGEs88fLSaY4AU1QBM4nUoqGKvHCl+zmeNL3h7BeYLUH3kGXOBzCzflaRQ5qsh6fMzi7benERxipnvlR+J4DtFZ8d+1J83N0yyz5Ch46R2POd3wUxjqvbYvJoklS3dqCySGWTvpO6DozCn6zGrRdnsWzRQFTDvlSV7ppwEXfLIJe/Ea9a/PHxeN6qrcrZumsFVBisNigCYDhrWD31JZeBzTpyFi4r0YmzHJWuWYH2jzqWrlywKdo8jd21Q/xeuxBx/E/OeEY4yBCzoi3RZ+qYqYbACO6ag0tiEwEBWYn3KpvQWML5pYf5phKyGizc5w0vm135YUQBZTYJ2kuqRkDs/m2eUa37f4DxkSi9kJa8JGI38EGwKyxbZBZ6jG4Z8ITsygTEGfm1iBkT8IVJyJGPf414xxiPZTAo0FbV9+kbrXywhl61OXlfgxQZpXmCsmj4Hzpyw1Y X-Forefront-PRVS: 0211965D06 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39410400002)(39850400002)(39860400002)(39450400003)(39840400002)(24454002)(189002)(199003)(53936002)(6246003)(53546003)(3846002)(6116002)(47776003)(230700001)(66066001)(65956001)(65806001)(92566002)(2906002)(23746002)(4326007)(64126003)(31696002)(50466002)(86362001)(101416001)(76176999)(50986999)(54356999)(7736002)(33646002)(305945005)(83506001)(6666003)(2950100002)(105586002)(6916009)(106356001)(42186005)(31686004)(110136004)(38730400002)(68736007)(5660300001)(65826007)(6512007)(54906002)(36756003)(25786008)(189998001)(229853002)(6506006)(6486002)(8676002)(81166006)(81156014)(97736004)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1441;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR12MB1441;23:jEKnYQqZUrFlW77BlhZ+wDTjwT4pwoZSPueSY?= =?Windows-1252?Q?WV1amzf8/hBVHJGFueztkhGX7VVI6EBF73F0W3Jv5HnTf9UURa8YKUb/?= =?Windows-1252?Q?gbxJmYCtBV/QcWOJ/3HGvUYWfwi6JTy0NJaR8ejbUi0KK2GaEsRdbm3m?= =?Windows-1252?Q?SiDFKRZf5QGRx46Pnu10M3O4uAQPjrslifEI9BfnUeDNTMfaX2hmcZNp?= =?Windows-1252?Q?mQ76qAhi8xT2g/eS+vbjbjUwhUmvTiswODnbWtswFuUkLhGDsDbhzo6e?= =?Windows-1252?Q?bD2zBdp3OTBeM/o9cz4KaNdpCtuYKv5AvFfT5L/pXeIQuf5DnsXVbFsc?= =?Windows-1252?Q?jOGnCgM+xZMBP7peJPCKBX61ec0uTGFmuOF+hvZKB8PY8CGM8QHAXBXZ?= =?Windows-1252?Q?MK9nFAacJREhzvTE84pMpwcVBE+sozFGcSNVk3vL93fEjHvGRSFCCqmg?= =?Windows-1252?Q?EsD3aESs+JWQsMZ9w1QH8vAuL8kDYoddc/2l1qLPbvCWPbT2qKLN98Il?= =?Windows-1252?Q?JSsAc3bI1Npk/y4dku3oEmm/ylKm3p4iAP5LouGgdQ9pJEJdR9MvTGeN?= =?Windows-1252?Q?G6TCO021mgd+Bp35tsYj+5mZdz2lzSUT4uwOIkl3oQ8m6iauv0dYdCdv?= =?Windows-1252?Q?pNPZmIlQfDm29/R8/gHiN+6nL9XXU81y70VpsS4NKJZS2GhUN0qmgaLh?= =?Windows-1252?Q?YsSgLchMbK8o/3bJb8vzCeyGnSx5c9WpfHYPsVtxk0Ox+iaIpUraLVTr?= =?Windows-1252?Q?o8rkPavBr9FEfpuJXWbUnzLI4mLs7chpiFAC2yzN4CKxd4tNsYqTtmir?= =?Windows-1252?Q?2mzhKvnROB7ivd7QUkG4wo4Wnvhhx8ZAw+BPcftsxDk2IZeec9GyZF1A?= =?Windows-1252?Q?aMLmS/hbsuDYASE3nWaWSU9iham/9UvjKi88XA4rYRyX9aGQWkkEeBTI?= =?Windows-1252?Q?HNwtdg5TALDHNBRMjWlqY5iWoUPE7aSPrRBuz2NkOWCmAsg/yWCdImQl?= =?Windows-1252?Q?vbA1xBwdwNo3TX0gUo4hBm8yNV+Zh2nM8LLjhc7bMPHXnimtXxQAEX9W?= =?Windows-1252?Q?i9DwRAuuEtrqC3/xD4uuGEgvvRLcX0lhdgYmudx/IEfOaZCBOxxNRa5r?= =?Windows-1252?Q?Dqm9IBsA2OalyVytwn0spnZKknHAsv21H6CFPTczAInky12wm855OCGg?= =?Windows-1252?Q?IsLJAFC1NiN3HMgDWI01PC1S0LHRPy0NqxZ3+32NvDmefdD/h//j+hpx?= =?Windows-1252?Q?Nc/zQGcMzWxrf0dUPKa3Di5c3joM6E7zdjomWqgDRA6fDMemwWevarQv?= =?Windows-1252?Q?rLtlp2K8mjD5CA7wXzQBrE2l8ilo8OJLIcDJjOBI6uDfbyJNTNuJt/Hb?= =?Windows-1252?Q?gjr9qBvItWneeauKeiBIAvAoz2IkuAg6A6sNIZNhUTg6Mpr2wg7k6aUL?= =?Windows-1252?Q?C1mjhqRu1HGuI5zAgH4NlS9r6lHjb1YndOx35/KABcvhYoscusnb76AR?= =?Windows-1252?Q?KO2IBvbjMfD5YKcf81kA6u99D7Kmmi+jfQwaLPD1+0AnyRSKSyWtyY51?= =?Windows-1252?Q?OJ71hqtocXOKSbqVDSuatP0bLz24nU7DRxbSPhROyCoLx2quM1Ig1BSg?= =?Windows-1252?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1441;6:LBsGhXjbynYr+yHl/rdgrHeR0jptyhD5lOBDIZc8IOAS5BtEjKwuO8JRH/63yex+VT20el4aLPoMwraDvW6TWtQFyiZHhGOH8xphIlEBnbUVj7N2z5G/dy1VqcTLe3djrsBlD2+xrZV7ifw2f2TM1c3lymwt7eP/1+NHS49Wi9fdBMFY23tIu20Qr0UJ1ia3JkkNQX0ohffE448P91WCEeuPV/jafFPtCMLlGe+t33hoFkwd5+2KWYYZ4AkxySLmkcQ5kQfB/ogvtndPne4qODVYkHcEfzVVd+VLI2tA7gfF7vrXTGiFfiQ+tCUoTEjW5Gcqld+Ejuz1Oh4kpWUAHYfqxccWVm60JI2aen6SVZIHAfTA7EDKoukyRhrpn8WV+Dn4v8eZRsAKj4lQyNbjgIxMDYR8EBgzbXvkVixzpJs=;5:qdsDHNgvrWA2Qv4wuzAnJacHjOp0PrzZ9xGceZI5IuK2/7lx9kAL1MzXVdUkpBosge5c2UEYH2xZ2eZe68ZAFkxfOGulWfoDHiMnYdyv9DF9YtZ5Ieyd+XDpNdiTIoLgu6JOgAaNd7n2qV1dvtgN5FETxzPNu0JlBSzwMF2Zc5c=;24:2QiBWakmOl/P72c5QkHs1cOmsLpMZCtGhxoWTUkpHK2si27CbCIfAGpmxQhXrlcTtFMK9DbrrECYP77Ztqe6smYh8Qdl3C5oMLnwkn5iXZE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1441;7:vyFlqGvUtbgTd3WZ+pLiXzBIOCMcMalx5DHwf2OKQutNDzN6wXkZAOyOX8VUjvv9HwgC6+q4FmsdqdRfocfjPq3yXg5h82tf4Ju8mOmWDoV5Ms3B6fYWYm7NYkLplrO7MDhbq26sP0sZCTAazy+XZkFuDpPa4Ip1fsgYwfzECG2cW5NZ8kdQHxoX1JFhrmDeN3CJYaNWzVIE2TmRQtKhQASpicO0gePgi1LlyHd/vHoeu/VSTik8VE6KPhjZcqX9Cd5lQQaaBadL7DNi5hZnaCeC1lQyFDQne/JMxrkqHxMmRbUSvRby5hBG8txF9HMlRZMlfXbOWkRBObn78tSwav9rM0wsNFVHeBOOT6DkF/9AjKwfnCjOCtXf/cSLGCxM9QXvYN2FtxLJr12+QFIOcip0ItHZpzkN1Tc/OcmkuFMsf383p/0Y8aQHikspDqCvLPx4cGQ4LKM0YBDkUSP0X0pulF8wFgdne4cIxO/jS2vZ9A1gzTE0JrrBF9bz6bcQY4F1aweKgJpQzQ4HWGx2Zg==;20:K1m3wISiCFp4ujomCo0+XyITOWxNCMPY9EDFbuJPA5oSGh+DYwz0nT9uSn9HdeN1miSX9I5yiHnAdUpdG7G1KRgoL1BB7qYbWjBATo807fvtdChRgEUyeRRGsx62fbvpuRYrh05bJMqlnmSPc9LXyKulfwPsqGevgauA+aVKa6CG8XhhqdUN/rnA+5s5p4IlVM+jU+AsLjODrHNbP5X8IAmPTpSsBACDzCdGxx5OAJex/xR2Ulb0/Jy9y+CI3gU6 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2017 04:50:42.5513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1441 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter, On 1/23/17 19:33, Peter Zijlstra wrote: > On Mon, Jan 16, 2017 at 01:23:30AM -0600, Suravee Suthikulpanit wrote: >> static void perf_iommu_read(struct perf_event *event) >> { >> - u64 count = 0ULL; >> - u64 prev_raw_count = 0ULL; >> - u64 delta = 0ULL; >> + u64 count, prev; >> + s64 delta; > > I did send that email where I told I was mistaken with that suggestion, > right? Since the counter always increments (it does, right), a negative > delta does not make sense. Right, I sent this out before your reply email in V7. I'll change the delta back to u64. I'll fix this in V9. > >> struct hw_perf_event *hwc = &event->hw; >> >> amd_iommu_pc_get_set_reg_val(_GET_DEVID(event), >> @@ -330,18 +329,20 @@ static void perf_iommu_read(struct perf_event *event) >> IOMMU_PC_COUNTER_REG, &count, false); >> >> /* IOMMU pc counter register is only 48 bits */ >> - count &= 0xFFFFFFFFFFFFULL; >> + count &= GENMASK_ULL(48, 0); > > Why do you need that at all? If the counter is only 48 bits, what does > the hardware do with the upper bits? So, bit 48-63 are reserved. I just try to ensure that the HW does not use them for anything (also probably in the future). >> >> - prev_raw_count = local64_read(&hwc->prev_count); >> - if (local64_cmpxchg(&hwc->prev_count, prev_raw_count, >> - count) != prev_raw_count) >> - return; >> + prev = local64_read(&hwc->prev_count); > > I'm still not convinced you can do away with that cmpxchg. Ok, I can just leave the local64_read() in. Thanks, Suravee