Blah. Puke. Ug. Not your changes, Bart... which are ok, but incomplete. Here is the complete bugfix. There are two places where error conditions are not fully handled, and 'out_spin' can kfree(image), saving some code. The worst bug of the list... if the firmware copy_from_user failed.... we still load firmware [ie. questionable data] into EEPROM. -- Jeff Garzik | Building 1024 | Would you like a Twinkie? MandrakeSoft |