From: Brian Gerst <bgerst@didntduck.org>
To: Tigran Aivazian <tigran@veritas.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 mm init cleanup
Date: Sat, 18 Nov 2000 11:39:38 -0500 [thread overview]
Message-ID: <3A16B0CA.E48EFFE7@didntduck.org> (raw)
In-Reply-To: <Pine.LNX.4.21.0011181628220.1270-100000@saturn.homenet>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
Tigran Aivazian wrote:
>
> On Sat, 18 Nov 2000, Brian Gerst wrote:
>
> > Patch against test11. This patch moves the setting of %cr4 out of the
> > loops and makes the code a bit more readable. Tested with standard
> > pagetables, PSE, and PAE.
> >
> >
>
> Brian,
>
> while you were there, so close to paging_init() why not also correct the
> wrong comment at the top of the function? It talks about 0-4M pagetables
> whereas we really setup (see head.S) 0-8M.
>
> Regards,
> Tigran
Add this little patch then
--
Brian Gerst
[-- Attachment #2: mminit2.diff --]
[-- Type: text/plain, Size: 472 bytes --]
diff -urN linux-2.4.0t11p7/arch/i386/mm/init.c linux/arch/i386/mm/init.c
--- linux-2.4.0t11p7/arch/i386/mm/init.c Mon Oct 23 17:42:33 2000
+++ linux/arch/i386/mm/init.c Sat Nov 18 11:38:02 2000
@@ -437,7 +437,7 @@
}
/*
- * paging_init() sets up the page tables - note that the first 4MB are
+ * paging_init() sets up the page tables - note that the first 8MB are
* already mapped by head.S.
*
* This routines also unmaps the page at virtual kernel address 0, so
prev parent reply other threads:[~2000-11-18 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-18 16:22 Brian Gerst
2000-11-18 16:29 ` Tigran Aivazian
2000-11-18 16:39 ` Brian Gerst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A16B0CA.E48EFFE7@didntduck.org \
--to=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tigran@veritas.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®