mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: "Gregory Price (Meta)" <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com, akpm@linux-foundation.org,
	david@kernel.org, joshua.hahnjy@gmail.com, rakie.kim@sk.com,
	ying.huang@linux.alibaba.com
Subject: Re: [PATCH] mm/mempolicy: ignore a bind policy whose nodes have no memory
Date: Fri, 13 Nov 2026 15:16:34 -0500	[thread overview]
Message-ID: <3A1D94AE-CAAA-4DB9-86BD-CF11012B276A@nvidia.com> (raw)
In-Reply-To: <179460086396.482102.9206100238305098014.b4-reply@b4>

On 13 Nov 2026, at 15:14, Gregory Price (Meta) wrote:

> On 2026-11-13 14:47 -0500, Zi Yan wrote:
>> On 13 Nov 2026, at 14:26, Gregory Price (Meta) wrote:
>>
>>> apply_policy_zone() assumes that policy->nodes intersects N_MEMORY, so
>>> it reads a bind policy with no N_HIGH_MEMORY node as movable-only.
>>>
>>> On systems with CONFIG_CPUSETS=n, nothing rebinds policies when memory
>>> is removed, so offlining all memory on the nodes a bind policy names
>>> leaves it with none. The policy is then treated as movable-only, and
>>> movable allocations are restricted to nodes without memory.
>>>
>>> This results in allocations failures, a VM_FAULT_OOM leak, and then
>>> an infinitely retrying fault that hangs the process.
>>>
>>>   page allocation failure: order:0, mode:0x140dca ... nodemask=2
>>>   Huh VM_FAULT_OOM leaked out to the #PF handler. Retrying PF
>>>
>>> Ignore a bind policy whose nodes have no memory. policy_nodemask()
>>> already ignores a bind policy that does not intersect the cpuset.
>>> This covers hugetlb's policy_mbind_nodemask() as well.
>>>
>>> If the nodes regain memory, the policy applies again.
>>>
>>> CPUSETS=n with HOTREMOVE=y is unlikely a common configuration, so this
>>> isn't marked for stable.
>>
>> Also no Fixes?
>>
>
> It wasn't quite obvious what to tag exactly.  Since I don't think it's
> worth backporting, wasn't sure I should bother spending time on the
> Fixes tag.

I can imagine that. We probably can blame mbind or hotremove, but the
commit might be too old to be meaningful. It is all good now.

Best Regards,
Yan, Zi

      reply	other threads:[~2026-11-13 20:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 19:26 Gregory Price (Meta)
2026-11-13 19:47 ` Zi Yan
2026-11-13 20:14   ` Gregory Price (Meta)
2026-11-13 20:16     ` Zi Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A1D94AE-CAAA-4DB9-86BD-CF11012B276A@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=gourry@gourry.net \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rakie.kim@sk.com \
    --cc=ying.huang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®