mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manfred <manfred@colorfullife.com>
To: Andrew Morton <andrewm@uow.edu.au>, linux-kernel@vger.kernel.org
Subject: Q: netdevice interface change
Date: Sat, 23 Dec 2000 15:13:56 +0100	[thread overview]
Message-ID: <3A44B324.1E1E9AF1@colorfullife.com> (raw)

Hi Andrew,

I have 2 questions about your netdevice2.txt:
   http://www.uow.edu.au/~andrewm/linux/netdevice2.txt 

* is withdraw_netdevice() really required, can't unregister_netdev
check "hidden", and notify the protocols/hotplug based on that value?

* I don't like the backward compatibility section:

<<<<<<<<
Other things:

     #define HAVE_PUBLISH_NETDEV

          This is for 2.2-compatible drivers.  They can do this:

          #ifdef HAVE_PUBLISH_NETDEV
          #define init_etherdev prepare_etherdev
          #define publish_netdev(dev) do {} while (0)
          #define withdraw_netdev unregister_netdev
          #endif
>>>>>>>>

As far as I know Linus prefers backward compatibility the other way
around:

<<<<<<
A 2.4 driver that must remain compatible with 2.2 should use
the new interface and add these lines to their source file:

       #ifndef HAVE_PUBLISH_NETDEV
       #define prepare_etherdev init_etherdev
       #define publish_netdev(dev) do {} while (0)
       #define withdraw_netdev unregister_netdev
       #endif
>>>>>>

--
  Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

             reply	other threads:[~2000-12-23 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-23 14:13 Manfred [this message]
2000-12-23 15:05 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A44B324.1E1E9AF1@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=andrewm@uow.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®