From: Manfred <manfred@colorfullife.com>
To: mulder.abg@sni.de, jgarzik@mandrakesoft.com
Cc: linux-kernel@vger.kernel.org
Subject: Q: natsemi.c spinlocks
Date: Sat, 23 Dec 2000 18:45:52 +0100 [thread overview]
Message-ID: <3A44E4D0.E8F177B9@colorfullife.com> (raw)
Hi Jeff, Tjeerd,
I spotted the spin_lock in natsemi.c, and I think it's bogus.
The "simultaneous interrupt entry" is a bug in some 2.0 and 2.1 kernel
(even Alan didn't remember it exactly when I asked him), thus a sane
driver can assume that an interrupt handler is never reentered.
Donald often uses dev->interrupt to hide other races, but I don't see
anything in this driver (tx_timeout and netdev_timer are both trivial)
--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2000-12-23 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-23 17:45 Manfred [this message]
2000-12-24 0:54 ` Andrew Morton
2000-12-24 11:15 ` Manfred
2001-01-21 14:38 ` Jeff Garzik
2001-01-21 14:43 ` [PATCH] " Jeff Garzik
2001-01-22 7:06 ` Donald Becker
2001-01-22 8:51 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A44E4D0.E8F177B9@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mulder.abg@sni.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome