mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <andrewm@uow.edu.au>
To: Miles Lane <miles@megapathdsl.net>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	David Brownell <david-b@pacbell.net>,
	linux-kernel@vger.kernel.org
Subject: Re: Prerelease kernel will not hotplug a USB host-controller when it is  inserted into a Cardbus slot.
Date: Wed, 03 Jan 2001 23:40:49 +1100	[thread overview]
Message-ID: <3A531DD1.F5A691DC@uow.edu.au> (raw)
In-Reply-To: <3A53187B.9030601@megapathdsl.net>

Miles Lane wrote:
> 
> Hi Linus and Co.,
> 
> I am writing to let you know that in all test12-pre6+ kernels,
> I get a "Bad PCI invocation" error when hotplug attempts to
> handle the insertion of a USB host-controller into a Cardbus
> slot.

That message is coming from your hotplug scripts.

At approximately test12-o'clock the following change was made:

diff -u --recursive --new-file t12p7/linux/drivers/pci/pci.c linux/drivers/pci/pci.c
--- t12p7/linux/drivers/pci/pci.c       Thu Dec  7 15:56:26 2000
+++ linux/drivers/pci/pci.c     Thu Dec  7 12:21:51 2000
@@ -360,9 +360,9 @@
        if (!hotplug_path[0])
                return;
 
-       sprintf(class_id, "PCI_CLASS=%X", pdev->class);
-       sprintf(id, "PCI_ID=%X/%X", pdev->vendor, pdev->device);
-       sprintf(sub_id, "PCI_SUBSYS_ID=%X/%X", pdev->subsystem_vendor, pdev->subsystem_device);
+       sprintf(class_id, "PCI_CLASS=%04X", pdev->class);
+       sprintf(id, "PCI_ID=%04X:%04X", pdev->vendor, pdev->device);
+       sprintf(sub_id, "PCI_SUBSYS_ID=%04X:%04X", pdev->subsystem_vendor, pdev->subsystem_device);
        sprintf(bus_id, "PCI_SLOT_NAME=%s", pdev->slot_name);
 
        i = 0;

So I guess your PCI hotplug script hasn't caught up with this
change in the format of its arguments.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-01-03 13:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-03 12:18 Miles Lane
2001-01-03 12:40 ` Andrew Morton [this message]
2001-01-03 14:57 ` Prerelease kernel will not hotplug a USB host-controller when it isinserted " David Brownell
2001-01-04  0:49   ` Miles Lane
2001-01-04  1:43     ` Miles Lane
2001-01-04  1:48       ` Miles Lane
2001-01-04  2:25     ` Prerelease kernel will not hotplug a USB host-controller when itisinserted " David Brownell
2001-01-04  5:49       ` Prerelease kernel will not hotplug a USB host-controller when it is inserted " Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A531DD1.F5A691DC@uow.edu.au \
    --to=andrewm@uow.edu.au \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles@megapathdsl.net \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®