From: Manfred Spraul <manfred@colorfullife.com>
To: jgarzik@mandrakesoft.com, linux-kernel@vger.kernel.org
Cc: cherenkoff@telus.net
Subject: Re: Oops in rtl8139, and more
Date: Mon, 15 Jan 2001 18:25:14 +0100 [thread overview]
Message-ID: <3A63327A.1D2A873D@colorfullife.com> (raw)
The problem is clear:
rtl8139_resume() unconditionally restarts the hardware, even if the
network was not yet started.
The hardware immediately notices something, and sends an interrupt.
The oops happens during rtl8139_open():
the function calls request_irq(), but assumes that the interrupts are
still disabled from the initial rtl8139_init_one(). Thus an interrupt
arrives before the driver structures are initialized.
Jeff, it seems that rtl8139_suspend() and rtl8139_resume() should check
if the nic was opened before stopping/restarting the hardware.
> >>EIP; c01a180e <rtl8139_rx_interrupt+b6/264> <=====
> Trace; c01a1d53 <rtl8139_interrupt+cf/164>
> Trace; c010a16d <handle_IRQ_event+31/5c>
> Trace; c010a2d7 <do_IRQ+6b/ac>
> Trace; c0108f68 <ret_from_intr+0/20>
> Trace; c010a6a1 <setup_irq+81/98>
> Trace; c01a1c84 <rtl8139_interrupt+0/164>
> Trace; c010a3a8 <request_irq+90/ac>
> Trace; c01a067e <rtl8139_open+1e/128>
> Trace; c01f4f90 <dev_open+48/a4>
--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2001-01-15 17:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A63327A.1D2A873D@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=cherenkoff@telus.net \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®