Re: 2.4.2-pre1

[Jeff Garzik <jgarzik@mandrakesoft.com>]

Tom Rini wrote:
> Er, what exactly is the CONFIG_PREP stuff in this driver supposed to be
> for?  "CONFIG_PREP" doesn't exist anymore to start with, and secondly I'm
> not sure if any PReP boxes ever shipped with a riva card to start with.  The
> only real way to handle this in 2.4 is something like:
> #ifdef CONFIG_ALL_PPC /* CHRP/PMAC/PREP */
> #include <asm/processor.h>
> #define isPReP (_machine == _MACH_prep)
> #else
> #define isPReP 0
> #endif
> 
> That is, if there's really any need to test explicitly for a PReP box.
> I asked Ani Joshi about this a while ago, and he wasn't quite sure why they
> were in there either..

It looks like it might have come from drivers/video/clgenfb.c, perhaps
for use with big endian framebuffers?

If the driver works on PPC without CONFIG_PREP code, let's get rid of
it.

	Jeff


-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/