mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vladimir V. Saveliev" <vs@namesys.botik.ru>
To: torvalds@transmeta.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: typo in 2.4.1/fs/dquot.c
Date: Thu, 15 Feb 2001 15:24:51 +0300	[thread overview]
Message-ID: <3A8BCA93.A578E20@namesys.botik.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

Hi

The attached is a fix for typo in 2.4.1/fs/dquot.c. It is not fixed yet
in 2.4.2pre3.
This typo causes quotactl (Q_GETQUOTA & GRPQUOTA, ..) to return EPERM.

Jan Kara (jack@suse.cz) confirmed that this is really a typo and that
the fix is a right one.

Thanks,
vs


[-- Attachment #2: dquot.c.patch --]
[-- Type: text/plain, Size: 351 bytes --]

--- dquot.c.orig	Wed Feb 14 04:08:26 2001
+++ dquot.c	Wed Feb 14 04:09:00 2001
@@ -1536,7 +1536,7 @@
 			break;
 		case Q_GETQUOTA:
 			if (((type == USRQUOTA && current->euid != id) ||
-			     (type == GRPQUOTA && in_egroup_p(id))) &&
+			     (type == GRPQUOTA && !in_egroup_p(id))) &&
 			    !capable(CAP_SYS_RESOURCE))
 				goto out;
 			break;

                 reply	other threads:[~2001-02-15 12:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A8BCA93.A578E20@namesys.botik.ru \
    --to=vs@namesys.botik.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®