From: Manfred Spraul <manfred@colorfullife.com>
To: linux-kernel@vger.kernel.org
Subject: flush_page_to_ram() question in kernel/ptrace.c
Date: Thu, 08 Mar 2001 21:00:40 +0100 [thread overview]
Message-ID: <3AA7E4E8.5EACF817@colorfullife.com> (raw)
>From linux/kernel/ptrace.c, access_one_page():
> flush_cache_page(vma, addr);
>
> if (write) {
> maddr = kmap(page);
> memcpy(maddr + (addr & ~PAGE_MASK), buf, len);
> flush_page_to_ram(page);
> flush_icache_page(vma, page);
> kunmap(page);
> } else {
> maddr = kmap(page);
> memcpy(buf, maddr + (addr & ~PAGE_MASK), len);
> flush_page_to_ram(page);
^^^^^^^^^^^^^^^^^^^^^^
> kunmap(page);
> }
Is this flush required?
The memcpy read from the mapping, it didn't write.
--
Manfred
next reply other threads:[~2001-03-08 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-08 20:00 Manfred Spraul [this message]
2001-03-08 21:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AA7E4E8.5EACF817@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®