From: Marcel Holtmann <marcel@holtmann.org>
To: Harish Bandi <c-hbandi@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
Hemantg <hemantg@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
anubhavg@codeaurora.org, devicetree <devicetree@vger.kernel.org>,
mark.rutland@arm.com, obh+dt@kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998
Date: Mon, 25 Mar 2019 12:48:22 +0100 [thread overview]
Message-ID: <3AEE5277-5830-41FC-BC72-F5BE4B34B357@holtmann.org> (raw)
In-Reply-To: <1553513491-25763-3-git-send-email-c-hbandi@codeaurora.org>
Hi Harish,
> This patch enables regulators for the Qualcomm Bluetooth WCN3998
> controller.
>
> Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org>
> ---
> Changes in V4:
> - Removed new compatible WCN3998
> - changed wcn3990 to wcn399* to represent wcn399* family
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> index 824c0e2..de9cefa 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> @@ -11,20 +11,21 @@ Required properties:
> - compatible: should contain one of the following:
> * "qcom,qca6174-bt"
> * "qcom,wcn3990-bt"
> + * "qcom,wcn3998-bt"
>
> Optional properties for compatible string qcom,qca6174-bt:
>
> - enable-gpios: gpio specifier used to enable chip
> - clocks: clock provided to the controller (SUSCLK_32KHZ)
>
> -Required properties for compatible string qcom,wcn3990-bt:
> +Required properties for compatible string qcom,wcn399*-bt:
>
> - vddio-supply: VDD_IO supply regulator handle.
> - vddxo-supply: VDD_XO supply regulator handle.
> - vddrf-supply: VDD_RF supply regulator handle.
> - vddch0-supply: VDD_CH0 supply regulator handle.
>
> -Optional properties for compatible string qcom,wcn3990-bt:
> +Optional properties for compatible string qcom,wcn399*-bt:
>
> - max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt
>
> @@ -44,7 +45,7 @@ serial@7570000 {
>
> serial@898000 {
> bluetooth {
> - compatible = "qcom,wcn3990-bt";
> + compatible = "qcom,wcn399*-bt”;
I am not convinced that examples should have a * in the compatible string. So lets have Rob ack this one.
Regards
Marcel
next prev parent reply other threads:[~2019-03-25 11:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 11:31 [PATCH v4 0/2] Enable Bluetooth functionality for WCN3998 Harish Bandi
2019-03-25 11:31 ` [PATCH v4 1/2] Bluetooth: hci_qca: Added support " Harish Bandi
2019-03-25 11:49 ` Marc Gonzalez
2019-03-25 11:31 ` [PATCH v4 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998 Harish Bandi
2019-03-25 11:48 ` Marcel Holtmann [this message]
2019-03-25 11:36 [PATCH v4 0/2] Enable Bluetooth functionality for WCN3998 Harish Bandi
2019-03-25 11:36 ` [PATCH v4 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998 Harish Bandi
2019-03-25 16:29 ` Matthias Kaehlcke
2019-03-26 10:04 ` c-hbandi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEE5277-5830-41FC-BC72-F5BE4B34B357@holtmann.org \
--to=marcel@holtmann.org \
--cc=anubhavg@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=obh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®