mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: cw00.choi@samsung.com
Cc: myungjoo.ham@samsung.com, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: extcon-next: patch "extcon: max77843: Replace irqchip mask_invert with unmask_base" should be reverted
Date: Wed, 29 Jun 2022 14:09:26 +0100	[thread overview]
Message-ID: <3AvtDmBqK77YBE1XGCycEcGxreGWRJSQ@localhost> (raw)


Hi Chanwoo,

I just noticed that one of my patches wound up in extcon-next as
commit a7d674db4612 ("extcon: max77843: Replace irqchip mask_invert
with unmask_base").

That patch has been applied too early and should be reverted/dropped,
as it depends on changes made in my regmap-irq refactoring series[1].
My commit message was overly broad and didn't communicate that fact,
however. Unmask registers are in fact broken right now so the patch
doesn't work as advertised and will break the driver.

For avoidance of doubt my other two extcon patches you took,

    extcon: sm5502: Drop useless mask_invert flag on irqchip
    extcon: rt8973a: Drop useless mask_invert flag on irqchip

are safe to take early and do not need to be reverted.

[1]: https://lore.kernel.org/lkml/20220623211420.918875-1-aidanmacdonald.0x0@gmail.com/

Best regards,
Aidan

             reply	other threads:[~2022-06-29 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 13:09 Aidan MacDonald [this message]
2022-06-29 19:09 ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AvtDmBqK77YBE1XGCycEcGxreGWRJSQ@localhost \
    --to=aidanmacdonald.0x0@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®