mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <andrewm@uow.edu.au>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Steve Kieu <haiquy@yahoo.com>, linux-kernel@vger.kernel.org
Subject: Re: Kernel 2.4.5-ac2 OOPs when run pppd ?
Date: Tue, 29 May 2001 00:19:14 +1000	[thread overview]
Message-ID: <3B125E62.1DD4712E@uow.edu.au> (raw)
In-Reply-To: <20010528084855.10604.qmail@web10402.mail.yahoo.com> from "=?iso-8859-1?q?Steve=20Kieu?=" at May 28, 2001 06:48:55 PM <E154NQp-000386-00@the-village.bc.nu>

Alan Cox wrote:
> 
> > Yeas it is stil the same as 2.4.5-ac1, but did not
> > happen with 2.4.5; You can try running pppd in the
> > console (tty1) without any argument.
> 
> Looks like an interaction with the newer console locking code. The BUG() is
> caused when the ppp code tries to write to the console from inside an
> interrupt handler [now not allowed]

I wondered if there were more cases.

In the (as-yet-unsent) Linus patch I've added an

	if (in_interrupt()) {
		shout_loudly();
		return;
	}

in three places to catch this possibility.   I'll prepare
a -ac diff.


This is a fundamental problem.

- The console is a tty device
- tty devices are callable from interrupts
- the console is very stateful and needs locking
- the locking must be interrupt-safe (irqsave)
- the console is very slow.

net result: we block interrupts for ages.  It's
an exceptional situation.  I hope Linus buys this
line of reasoning :)

-

  reply	other threads:[~2001-05-28 14:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-28  8:48 Steve Kieu
2001-05-28 13:51 ` Alan Cox
2001-05-28 14:19   ` Andrew Morton [this message]
2001-05-28 18:21   ` Richard Gooch
2001-05-29  1:12     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B125E62.1DD4712E@uow.edu.au \
    --to=andrewm@uow.edu.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=haiquy@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®