Sock leak in net/ipv4/af_inet.c - 2.4.26

["Dickey, Dan" <Dan.Dickey@savvis.net>]

Alexey & Dave,
I hope these are good addresses for you - it has been a few years since
I've tried to contact you.

I've found a leak in af_inet.c, routine inet_create().
It allocates from the sock slab using sk_alloc(), but
sk_free() is never called on these sock structs.
I'm not that familiar with the af_inet code, but I'll
continue taking a look at it to try and determine where
the missing sk_free() is supposed to be.
If either of you or anyone else has an idea, please
let me know.  We have several 2GB mem systems that need
to be rebooted every few days because of this problem.

Oh - by the way, it looks like this is happening in
net/ipv4/tcp_minisocks.c as well.  Routine tcp_create_openreq_child().
There is no corresponding sk_free() call for the sk_alloc() in here.

In order to track these down, I've added some simple debug code
around the sk_alloc/sk_free calls to track allocations.  I know
where the leaky sock structs are being allocated from, but not
where they should be freed.

The bugzilla.kernel.org bug # is 2676.
	-Dan

------
Dan A. Dickey
dan.dickey@savvis.net