From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Ion Badulescu <ionut@cs.columbia.edu>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] starfire net driver update
Date: Tue, 10 Jul 2001 12:49:13 -0400 [thread overview]
Message-ID: <3B4B3209.40F5519F@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0107100932230.13462-100000@age.cs.columbia.edu>
Ion Badulescu wrote:
> + unregister_netdev(dev); /* Will also free np!! */
> + iounmap((char *)dev->base_addr);
> + pci_release_regions(pdev);
>
> pci_set_drvdata(pdev, NULL);
> + kfree(dev);
no problem with the patch, this comment is wrong though. kfree frees
np.
--
Jeff Garzik | A recent study has shown that too much soup
Building 1024 | can cause malaise in laboratory mice.
MandrakeSoft |
next prev parent reply other threads:[~2001-07-10 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-10 16:36 Ion Badulescu
2001-07-10 16:49 ` Jeff Garzik [this message]
2001-07-10 17:24 ` Ion Badulescu
2001-07-11 14:33 ` Juri Haberland
2001-07-11 14:48 ` Ion Badulescu
2001-07-11 15:16 ` Juri Haberland
2001-07-12 6:51 ` Ion Badulescu
2001-07-12 10:34 ` Juri Haberland
2001-07-12 14:14 ` Ion Badulescu
2001-07-12 15:49 ` Juri Haberland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B4B3209.40F5519F@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ionut@cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®