mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Alexander Viro <viro@math.psu.edu>
Cc: Greg Louis <glouis@dynamicro.on.ca>,
	ext3-users <ext3-users@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: ac4 ext3 recovery failure
Date: Fri, 03 Aug 2001 12:58:34 -0700	[thread overview]
Message-ID: <3B6B026A.C2D741B2@zip.com.au> (raw)
In-Reply-To: <3B6AFBD1.5F43B496@zip.com.au> <Pine.GSO.4.21.0108031534210.3272-100000@weyl.math.psu.edu>

Alexander Viro wrote:
> 
> On Fri, 3 Aug 2001, Andrew Morton wrote:
> 
> > Do you think this happened during the e2fsck run, or during the
> > actual mount?
> 
> actual mount. s/fsync_dev/fsync_no_super/ in fs/jbd/*. Already fixed
> in Alan's tree.

Ah.  Thanks.  Linus doesn't seem to have fsync_no_super(), so some
compatibility hacks will be needed there.

Why does fsync_no_super() exist?  I assume some locking changes
somewhere?

> BTW, code around the place in question looks somewhat fishy - looks
> like you have a lot of stuff assuming that journal and fs are on the
> same device.

Yes - this was fixed up when we were testing the external journal
support for 0.9.5.  -ac4 has 0.9.3+bits.

-

  reply	other threads:[~2001-08-03 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-03 12:24 Greg Louis
2001-08-03 19:30 ` Andrew Morton
2001-08-03 19:38   ` Alexander Viro
2001-08-03 19:58     ` Andrew Morton [this message]
2001-08-03 20:03       ` Alexander Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B6B026A.C2D741B2@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=ext3-users@redhat.com \
    --cc=glouis@dynamicro.on.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®