From: Adrian Cox <adrian@humboldt.co.uk>
To: Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Filling holes in ext2
Date: Thu, 23 Aug 2001 22:21:20 +0100 [thread overview]
Message-ID: <3B8573D0.1000904@humboldt.co.uk> (raw)
In-Reply-To: <3B83E9FD.6020801@humboldt.co.uk> <3B83FB3F.A0BDC056@zip.com.au> <3B853BE6.3010703@humboldt.co.uk> <3B854186.F0C00E3C@zip.com.au> <3B8556B6.7040700@humboldt.co.uk> <3B855C62.85BC16E7@zip.com.au>
Andrew Morton wrote:
> Ah. Now I'm with you. Yes, we need a better cleanup facility
> to handle this.
>
> We can sort-of fudge it with commit_write():
[snip]
> Which is OK for mid-file blocks, but will cause i_size to be extended
> at eof, which probably isn't too bad. Needs more thought.
That certainly stops it happening. Does anybody think that extending
i_size in this particular corner case is harmful?
As Alan said, the bug is the file system committing metadata too early,
and I suspect that ext2 is not the only culprit.
--
Adrian Cox http://www.humboldt.co.uk/
next prev parent reply other threads:[~2001-08-23 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-22 17:21 Adrian Cox
2001-08-22 18:34 ` Andrew Morton
2001-08-22 18:59 ` Adrian Cox
2001-08-23 17:22 ` Adrian Cox
2001-08-23 17:46 ` Andrew Morton
2001-08-23 19:17 ` Adrian Cox
2001-08-23 19:23 ` Alan Cox
2001-08-23 19:41 ` Andrew Morton
2001-08-23 21:21 ` Adrian Cox [this message]
2001-08-23 17:47 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B8573D0.1000904@humboldt.co.uk \
--to=adrian@humboldt.co.uk \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®