Hi everyone,


I've posted the majority of this before (against 2.4.13-pre2), but I
never got any response (probably partially becourse my clock was set
24hrs into the past). 

I have updated the patch against 2.4.13-pre3 and added a fix for a minor
typo in panic.c
I'm posting this to the list to get comments about these cleanups, not
becourse I expect to get any part of this accepted into the kernel at
this point. I would very much like to know if these cleanups are worth
the effort and if what I have done looks allright. Any constructive
criticism is very much appreciated.


Here's a summary of what the patch does:


init/main.c : root_dev_setup()
        In the for() loop the counter "i" is compared to "sizeof
root_device_name". "i" is declared as int
        (signed) and sizeof always returns an unsigned value, so I
believe "i" should be declared unsigned.

init/main.c : parse_options()
        The check that adds "line" to either "envp_init" or "argv_init"
checks to see if the buffers are full
        and break;s the while() loop if _either_ buffer is full - it
should use continue; so both buffers can
        get a chance to fill up.
        Robert M. Love should get credit for finding this one, I found
it by looking at an old patch of his, and
        I just checked to see if it was still there and read the code to
see if it was correct.

kernel/exec_domain.c :
        Contrary to most other files in the kernel source the functions
in exec_domain.c are defined with the
        return values on a line by themselves. Most places in kernel
source have the entire function definition
        on a single line (as long as it does not exceed 80 chars in
length). So I moved the function definitions
        onto a single line.

kernel/exec_domain.c : get_exec_domain_list()
        The len variable (signed) is compared to PAGE_SIZE (unsigned).
Changing len to "unsigned int" avoids
        comparison between signed and unsigned.

        It seems that there are tons of places throughout the kernel
where signed and unsigned variables are
        compared. I won't mind going through the source and try to see
where this can be avoided easily, but I'm
        not sure it it's worth the effort?

kernel/panic.c : panic()
	There's a small typo in the text that's printk()'d to the user - it
says "...the boot prom\n" where I believe it should say "...the boot
prompt\n".


The patch itself is attached as "2.4.13-pre3-jj1.patch". 
Since these changes are all very minor I have included them all in a
single patch file, but I can split them out into 3 individual patches on
request.


Best regards,
Jesper Juhl
juhl@eisenstein.dk