mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
Cc: Keith Owens <kaos@ocs.com.au>,
	Linux-Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: PATCH 2.4.17.2: make ext2 smaller
Date: Sun, 02 Dec 2001 08:47:58 -0500	[thread overview]
Message-ID: <3C0A310E.513903CB@mandrakesoft.com> (raw)
In-Reply-To: <3C0A1105.18B76D64@mandrakesoft.com> <25560.1007294074@ocs3.intra.ocs.com.au> <20011202133314.B717@nightmaster.csn.tu-chemnitz.de> <3C0A269F.D2B1D3@mandrakesoft.com> <20011202144019.A741@nightmaster.csn.tu-chemnitz.de>

Ingo Oeser wrote:
> 
> On Sun, Dec 02, 2001 at 08:03:27AM -0500, Jeff Garzik wrote:
> > Ingo Oeser wrote:
> > > Even this doesn't have to be done manually. Everything that is
> > > not covered by EXPORT_SYMBOL() in this case can be static, since
> >
> > And if !MODULE, then even EXPORT_SYMBOL symbols can become static, if
> > they are not used outside the compilation unit.
> 
> If your compilation units are greater than the current
> granularity of modules: Yes.
> 
> EXPORT_SYMBOL() symbols are Kernel-API, which is also exported to
> 3rd-party vendors with binary modules. So it makes little sense
> to me to make them static.

If !MODULES, modules are not supported by that kernel.  It is completely
safe to make such functions static, if not used outside the compilation
unit.  For all other cases, it is indeed wrong to make such them static.

	Jeff


-- 
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno


  reply	other threads:[~2001-12-02 13:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-02 11:31 Jeff Garzik
2001-12-02 11:54 ` Keith Owens
2001-12-02 12:33   ` Ingo Oeser
2001-12-02 13:00     ` PATCH 2.4.17.2: CONFIG_FINAL, make kernel smaller Jeff Garzik
2001-12-02 13:07       ` Jeff Garzik
2001-12-02 13:03     ` PATCH 2.4.17.2: make ext2 smaller Jeff Garzik
2001-12-02 13:40       ` Ingo Oeser
2001-12-02 13:47         ` Jeff Garzik [this message]
2001-12-02 13:53           ` Ingo Oeser
2001-12-02 16:14 ` Christer Weinigel
2001-12-02 16:44 ` Martin Dalecki
2001-12-02 17:42   ` Jeff Garzik
2001-12-02 21:30 ` Andrew Morton
2001-12-02 21:35   ` Jeff Garzik
2001-12-03  2:53 ` Horst von Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0A310E.513903CB@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=ingo.oeser@informatik.tu-chemnitz.de \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®