From: Albert Cranford <ac9410@bellsouth.net>
To: ollie@sis.com.tw, linux-kernel@vger.kernel.org,
Keith Owens <kaos@ocs.com.au>
Subject: [PATCH]take2 2.4.18-pre1 sound/trident fix with newer binutils
Date: Wed, 02 Jan 2002 09:06:28 -0500 [thread overview]
Message-ID: <3C3313E4.10B5E0D2@bellsouth.net> (raw)
Take 2. Mistake in previous patch. Sorry.
Hello Ollie,
Small problem.
I cannot build kernel with binutils-2.11.92.0.12.3
Using ARCH='i386' AS='as' LD='ld' CC='/usr/bin/gcc' CPP='/usr/bin/gcc -E' AR='ar' HOSTAS='as' HOSTLD='gcc' HOSTCC='gcc' HOSTAR='ar'
drivers/sound/trident.o(.data+0x154): undefined reference to `local symbols in discarded section .text.exit'
Please submit the attached patch to Marcelo and Linus
for 2.4 and 2.5 respectfully. This patch also works
with older binutils-2.11.2
Thanks,
Albert
--- trident.c.orig Wed Jan 2 06:36:12 2002
+++ trident.c Wed Jan 2 08:59:09 2002
@@ -4141,7 +4141,7 @@
goto out;
}
-static void __exit trident_remove(struct pci_dev *pci_dev)
+static void __devexit trident_remove(struct pci_dev *pci_dev)
{
int i;
struct trident_card *card = pci_get_drvdata(pci_dev);
@@ -4194,7 +4194,7 @@
name: TRIDENT_MODULE_NAME,
id_table: trident_pci_tbl,
probe: trident_probe,
- remove: trident_remove,
+ remove: __devexit_p(trident_remove),
suspend: trident_suspend,
resume: trident_resume
};
@@ -4214,7 +4214,7 @@
return 0;
}
-static void __exit trident_cleanup_module (void)
+static void __devexit trident_cleanup_module (void)
{
pci_unregister_driver(&trident_pci_driver);
}
--
Albert Cranford Deerfield Beach FL USA
ac9410@bellsouth.net
next reply other threads:[~2002-01-02 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-02 14:06 Albert Cranford [this message]
2002-01-02 19:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3313E4.10B5E0D2@bellsouth.net \
--to=ac9410@bellsouth.net \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=ollie@sis.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®