From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
Alexander Viro <viro@math.psu.edu>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [RFC] Unbork fs.h, 1 of 4
Date: Sun, 06 Jan 2002 17:37:39 -0500 [thread overview]
Message-ID: <3C38D1B3.51724D66@mandrakesoft.com> (raw)
In-Reply-To: <E16NLbK-0001LE-00@starship.berlin>
I share the opinion of a couple others, to use generic_ip and
generic_sbp. That's what they are there for.
May I suggest the course of action whereby you convert the code to use
ext2_sb(sb) and ext2_i(inode) first, without changing fs.h at all. That
lays the groundwork for arguing out the final solution, and the code is
much cleaner either way.
I have not seen anyone arguing -against- ext2_sb() and ext2_i()
cleanups... they seem to make the code obviously more clean.
After those cleanups go in, your further "unbork fs.h" patches will be
smaller and only show the core changes you are interested in.
Jeff
--
Jeff Garzik | Alternate titles for LOTR:
Building 1024 | Fast Times at Uruk-Hai
MandrakeSoft | The Took, the Elf, His Daughter and Her Lover
| Samwise Gamgee: International Hobbit of Mystery
next prev parent reply other threads:[~2002-01-06 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-06 22:17 Daniel Phillips
2002-01-06 22:37 ` Jeff Garzik [this message]
2002-01-06 22:48 ` Daniel Phillips
2002-01-07 0:27 ` Daniel Phillips
2002-01-07 2:47 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C38D1B3.51724D66@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=acme@conectiva.com.br \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®