From: "Udo A. Steinberg" <reality@delusion.de>
To: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.5.4-pre6 apm compile fix
Date: Mon, 11 Feb 2002 03:26:48 +0100 [thread overview]
Message-ID: <3C672BE8.EF4C703F@delusion.de> (raw)
Hi Linus,
The attached patch fixes the following compiler warning in -pre6:
apm.c: In function `apm_mainloop':
apm.c:1376: warning: comparison between pointer and integer
apm.c:1384: warning: comparison between pointer and integer
nr_running is really a function and not an integer.
I believe this had already been applied in earlier 2.5 and then somehow
vanished, probably due to an update by whoever maintains apm.c
Regards,
-Udo.
--- linux-2.5.4-pre-vanilla/arch/i386/kernel/apm.c Mon Feb 11 03:04:25 2002
+++ linux-2.5.4-pre/arch/i386/kernel/apm.c Mon Feb 11 03:04:51 2002
@@ -1348,7 +1348,7 @@
* decide if we should just power down.
*
*/
-#define system_idle() (nr_running == 1)
+#define system_idle() (nr_running() == 1)
static void apm_mainloop(void)
{
next reply other threads:[~2002-02-11 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-11 2:26 Udo A. Steinberg [this message]
2002-02-11 3:02 ` Alan Cox
2002-02-12 1:21 ` Stephen Rothwell
2002-02-12 16:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C672BE8.EF4C703F@delusion.de \
--to=reality@delusion.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®