From: Borislav Petkov <bp@alien8.de>
To: John Allen <john.allen@amd.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/CPU/AMD: Only apply Zenbleed fix for Zen2 during late microcode load
Date: Mon, 23 Sep 2024 18:02:28 +0200 [thread overview]
Message-ID: <3C79F091-A19B-4BAD-8582-56961830AF25@alien8.de> (raw)
In-Reply-To: <20240923154112.26985-1-john.allen@amd.com>
On September 23, 2024 5:41:12 PM GMT+02:00, John Allen <john.allen@amd.com> wrote:
>A problem was introduced with f69759b ("x86/CPU/AMD: Move Zenbleed check to
Use 12 chars for the commit id.
>the Zen2 init function") where a bit in the DE_CFG MSR is getting set after
>a microcode late load.
>
>The problem is that the microcode late load path calls into
>amd_check_microcode and subsequently zen2_zenbleed_check. Since the patch
>removes the cpu_has_amd_erratum check from zen2_zenbleed_check, this will
End all function names with "()".
>cause all non-Zen2 cpus to go through the function and set the bit in the
>DE_CFG MSR.
>
>Call into the zenbleed fix path on Zen2 cpus only.
s/cpus/CPUs/g
And yes, it should be cc:stable.
With all that addressed, you can add:
Acked-by: me
to the patch.
Thx.
--
Sent from a small device: formatting sucks and brevity is inevitable.
prev parent reply other threads:[~2024-09-23 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 15:41 John Allen
2024-09-23 15:56 ` John Allen
2024-09-23 16:02 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C79F091-A19B-4BAD-8582-56961830AF25@alien8.de \
--to=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®