From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135C8EB64DD for ; Tue, 4 Jul 2023 21:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbjGDVhA (ORCPT ); Tue, 4 Jul 2023 17:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbjGDVg5 (ORCPT ); Tue, 4 Jul 2023 17:36:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A37DE59; Tue, 4 Jul 2023 14:36:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E749161381; Tue, 4 Jul 2023 21:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F1F9C433C7; Tue, 4 Jul 2023 21:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688506614; bh=eKyZ9PkJ+ke344sHii+bCX3P4/oDphlbXbihKHuI0wc=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=KbyZEpz7LvuMZPUZ+VDakZRe1vQSYrRAkkHStQga6b9oeMtoBkNCgunC864yhA5lO NrrRbVrBbsrq2SCSESAQjQtGu9y56YMwKa5cleuC1UbKT4h68/vEl7/L54aBckiYb1 Iy4TyoOW9Loq0nnh0NyFEPTe79+ee65BGcRGn9EGtaWpqGjxNUtmjUITBGrShJtVjE i0Qyjjx9XtP4sHAB/K5OHDYyczO0nQlDIziJLgcpRQXUmTWwVNqDqsnXSA7+5rZdtP lM8HgFiGDSkEsY3JVKafmZqkYGV3KDqLW52mbn8ypfUeIJJPvHj8T3TKvNxmc/SC4P NONZUDeTMYycA== Date: Tue, 04 Jul 2023 14:36:51 -0700 From: Kees Cook To: Mirsad Todorovac , Kees Cook CC: Guenter Roeck , Bagas Sanjaya , Linux Kernel Mailing List , Linux LLVM , linux-kbuild@vger.kernel.org, Linux Regressions , Nathan Chancellor , Nick Desaulniers , linux-hardening@vger.kernel.org Subject: Re: [CRASH][BISECTED] 6.4.1 crash in boot User-Agent: K-9 Mail for Android In-Reply-To: References: <9a8e34ad-8a8b-3830-4878-3c2c82e69dd9@alu.unizg.hr> <202307022018.B26F5795@keescook> <625e951e-9922-d15d-5520-e8cd5eba1995@roeck-us.net> <4fa56264-f188-46f9-cc77-117b469b3328@roeck-us.net> <2b1a4f49-ba18-0246-af09-4e4133814411@alu.unizg.hr> <202307022230.6121D6896@keescook> <202307031149.823F9A3@keescook> <202307031606.3FD9D0D@keescook> Message-ID: <3CDD1188-7B2A-4D53-9B8F-C07BC39844E9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On July 4, 2023 10:20:11 AM PDT, Mirsad Todorovac wrote: >On 7/4/23 01:09, Kees Cook wrote:> On Mon, Jul 03, 2023 at 12:03:23PM -07= 00, Kees Cook wrote: >>> Cool=2E xhci-hub is in your backtrace, and the above patch was made fo= r >>> something very similar (though, again, I don't see why you're getting = a >>> _crash_, it should _warn_ and continue normally)=2E And, actually, als= o >>> include this patch: >>> https://lore=2Ekernel=2Eorg/lkml/20230614181307=2Egonna=2E256-kees@ker= nel=2Eorg/ >>=20 >> This is now in Linus's tree: >> 09b69dd4378b ("usb: ch9: Replace 1-element array with flexible array") >>=20 >> Please also still try with the first patch I mentioned, which is very s= imilar: >> https://lore=2Ekernel=2Eorg/lkml/20230629190900=2Enever=2E787-kees@kern= el=2Eorg/ > >Hi, > >I have finally built w both patches (and recommended PSTORE settings were >default already)=2E Were you able to find the crashes saved by pstore? > >This second patch fixes the booting problem, but alas there is still a pr= oblem - Ah! That's great! They're is still an unexpected crash source, but the tri= gger is fixed=2E >all Wayland and X11=2Eorg GUI applications fail to start, with errors lik= e this one: > >Jul 4 19:09:07 defiant kernel: [ 40=2E529719] invalid opcode: 0000 [#1= ] PREEMPT SMP NOPTI Hmm, is CONFIG_UBSAN_TRAP set? >Jul 4 19:09:07 defiant kernel: [ 40=2E529726] RIP: 0010:alloc_pid+0x46= c/0x480 Hmm, is this patch in your kernel? https://git=2Ekernel=2Eorg/linus/b69f0aeb068980af983d399deafc7477cec8bc04 --=20 Kees Cook